Skip to content

Commit

Permalink
Make the diagnostic log downloader logs clearly say what they are.
Browse files Browse the repository at this point in the history
Just saying "BDX" can make people think this is OTA.
  • Loading branch information
bzbarsky-apple committed Sep 25, 2024
1 parent 34c0fe1 commit 12379bf
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/darwin/Framework/CHIP/MTRDiagnosticLogsDownloader.mm
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,7 @@ - (void)handleBDXTransferSessionBeginForFileDesignator:(NSString *)fileDesignato
abortHandler:(AbortHandler)abortHandler;
{
assertChipStackLockedByCurrentThread();
MTR_LOG("BDX Transfer Session Begin: %@", fileDesignator);
MTR_LOG("BDX Transfer Session Begin for log download: %@", fileDesignator);

auto * download = [_downloads get:fileDesignator fabricIndex:fabricIndex nodeID:nodeID];
VerifyOrReturn(nil != download, completion([MTRError errorForCHIPErrorCode:CHIP_ERROR_NOT_FOUND]));
Expand All @@ -492,7 +492,7 @@ - (void)handleBDXTransferSessionDataForFileDesignator:(NSString *)fileDesignator
completion:(MTRStatusCompletion)completion
{
assertChipStackLockedByCurrentThread();
MTR_LOG("BDX Transfer Session Data: %@: %@", fileDesignator, data);
MTR_LOG("BDX Transfer Session Data for log download: %@: %@", fileDesignator, data);

auto * download = [_downloads get:fileDesignator fabricIndex:fabricIndex nodeID:nodeID];
VerifyOrReturn(nil != download, completion([MTRError errorForCHIPErrorCode:CHIP_ERROR_NOT_FOUND]));
Expand All @@ -510,7 +510,7 @@ - (void)handleBDXTransferSessionEndForFileDesignator:(NSString *)fileDesignator
error:(NSError * _Nullable)error
{
assertChipStackLockedByCurrentThread();
MTR_LOG("BDX Transfer Session End: %@: %@", fileDesignator, error);
MTR_LOG("BDX Transfer Session End for log download: %@: %@", fileDesignator, error);

auto * download = [_downloads get:fileDesignator fabricIndex:fabricIndex nodeID:nodeID];
VerifyOrReturn(nil != download);
Expand Down

0 comments on commit 12379bf

Please sign in to comment.