Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added setting for python-specific connection URL #10439

Closed

Conversation

Floris-Hyve
Copy link
Contributor

@Floris-Hyve Floris-Hyve commented Oct 19, 2023

Problem:

Standard database connection string does not work when using MySQL python connector for migration. For example, ssl connection is disabled for the standard connection URL, but ssl connection is required for python MySQL connection.

Fix:

Added Python-specific connection URL, and implemented it in the get_database_properties function, so the correct URL is selected for the migration script.

Input URL is given in the portal.properties:

db.connection_string_python=

@Floris-Hyve Floris-Hyve added python Pull requests that update Python code backend labels Oct 23, 2023
@Floris-Hyve Floris-Hyve marked this pull request as ready for review October 23, 2023 07:53
Copy link
Contributor

@pvannierop pvannierop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes.

src/main/resources/portal.properties.EXAMPLE Outdated Show resolved Hide resolved
Copy link
Contributor

@pvannierop pvannierop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two proposed changes:

  1. Clean up the commits (now there are 7!)
  2. Harmonize information on precedence of the URL properties.

…using both python and java at the entrypoint.
@Floris-Hyve Floris-Hyve force-pushed the connection-string-python branch from 694cf4b to 8706178 Compare November 1, 2023 12:53
Copy link

sonarqubecloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link

sonarqubecloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@alisman alisman requested a review from JREastonMarks December 5, 2023 16:22
@JREastonMarks
Copy link
Contributor

From an RFC72 (6.0) perspective the core module has been moved out of the cbioportal code base and into its own code base here: https://github.com/cBioPortal/cbioportal-core

@pvannierop can you create another PR for this in that repo? That way it will work in both 5.X and 6.X versions of cBioPortal.

@alisman
Copy link
Contributor

alisman commented Jan 22, 2024

@JREastonMarks can you provide direction on how re-target this PR in a 6.0 world.

@JREastonMarks
Copy link
Contributor

Hi @Floris-Hyve,
With the release of 6.0.0 (RFC72) we moved a lot of code around and updated some of the files that you reference in this PR. The core module has been moved to its own repository: https://github.com/cBioPortal/cbioportal-core. If you move this PR to the core package it should still be a quick change. Please let me know if you need any help.

@JREastonMarks
Copy link
Contributor

Closing but willing to reopen if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants