-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added setting for python-specific connection URL #10439
Added setting for python-specific connection URL #10439
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two proposed changes:
- Clean up the commits (now there are 7!)
- Harmonize information on precedence of the URL properties.
…using both python and java at the entrypoint.
694cf4b
to
8706178
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
From an RFC72 (6.0) perspective the core module has been moved out of the cbioportal code base and into its own code base here: https://github.com/cBioPortal/cbioportal-core @pvannierop can you create another PR for this in that repo? That way it will work in both 5.X and 6.X versions of cBioPortal. |
@JREastonMarks can you provide direction on how re-target this PR in a 6.0 world. |
Hi @Floris-Hyve, |
Closing but willing to reopen if needed. |
Problem:
Standard database connection string does not work when using MySQL python connector for migration. For example, ssl connection is disabled for the standard connection URL, but ssl connection is required for python MySQL connection.
Fix:
Added Python-specific connection URL, and implemented it in the get_database_properties function, so the correct URL is selected for the migration script.
Input URL is given in the portal.properties:
db.connection_string_python=