genetable version added to info api #11290
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inodb
reviewed
Jan 10, 2025
There was a problem hiding this comment.
Thanks so much @rajeswari2904 ! Made a few comments. The db.version is a bit different from genetable.version - might be good to discuss more if you're still working on this. Feel free to slack me. Thank you!
| @@ -31,7 +31,7 @@ | |||
|
|
|||
| <!-- THIS SHOULD BE KEPT IN SYNC TO VERSION IN CGDS.SQL --> | |||
| <db.version>2.13.1</db.version> | |||
|
|
|||
| <genetable.version>hgnc_v2023.10.1</genetable.version> | |||
There was a problem hiding this comment.
@rajeswari2904 should this be pulled from the SQL instead? Do we need to hardcode it in the pom?
There was a problem hiding this comment.
I think the genetable.version is a bit different from db.version
- the
db.versionindicates the version of the SQL schema. The backend is only compatible with a specific version of this schema - for the genetable version is fine if it differs with the backend code version. No need to hardcode the version in the pom.xml. Whoever loads the gene table data should indicate what version it is
inodb
reviewed
Jan 10, 2025
| @@ -755,5 +756,5 @@ CREATE TABLE `resource_study` ( | |||
| ); | |||
|
|
|||
| -- THIS MUST BE KEPT IN SYNC WITH db.version PROPERTY IN pom.xml | |||
| INSERT INTO info VALUES ('2.13.1', NULL); | |||
| INSERT INTO info VALUES ('2.13.1','hgnc_v2023.10.1', NULL ); | |||
There was a problem hiding this comment.
This version should maybe be N/A or empty string. Whoever loads the gene table data should set the version
inodb
reviewed
Jan 10, 2025
| @@ -1027,4 +1027,6 @@ ALTER TABLE `clinical_event_data` MODIFY COLUMN `VALUE` varchar(3000) NOT NULL; | |||
| CREATE INDEX idx_clinical_event_key ON clinical_event_data (`KEY`); | |||
| CREATE INDEX idx_clinical_event_value ON clinical_event_data (`VALUE`); | |||
| CREATE INDEX idx_sample_stable_id ON sample (`STABLE_ID`); | |||
| ALTER TABLE `info` ADD COLUMN `GENE_TABLE_VERSION` varchar(24); | |||
| UPDATE `info` SET `GENE_TABLE_VERSION`="hgnc_v2023.10.1"; | |||
There was a problem hiding this comment.
same here also good if the version is empty or N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10299