Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom sample filtering performance and security improvement #11296

Merged

Conversation

dippindots
Copy link
Member

Fix #11195

  • concat has poor performance during my test, we should try to not use concat in a large foreach clause
  • clickhouse support native array in the query, and it has better performance, try replace large foreach with array

In this pull request:

  • Change back from string to prepared statement for security reason
  • Use native array to improve performance

@dippindots dippindots marked this pull request as draft December 19, 2024 15:51
@dippindots dippindots force-pushed the demo-fix-prepared-statements branch from 80deff7 to 8607377 Compare December 19, 2024 16:14
@haynescd haynescd marked this pull request as ready for review December 19, 2024 16:24
@haynescd haynescd self-requested a review December 19, 2024 16:24
@alisman alisman merged commit 6d58f8f into cBioPortal:demo-rfc80-poc Dec 19, 2024
15 of 18 checks passed
@dippindots dippindots deleted the demo-fix-prepared-statements branch December 27, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants