-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#281) Bump GH-Action images to latest #282
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #282 +/- ##
========================================
Coverage 96.42% 96.42%
========================================
Files 4 4
Lines 112 112
Branches 17 17
========================================
Hits 108 108
Misses 1 1
Partials 3 3 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@AdmiringWorm Everything is working again, apart from mergify which seems to be broken because of https://blog.mergify.com/strict-mode-deprecation/. However, I have no idea how to fix that in a meaningful way. |
and added the required dotnet versions
This will get us Cake 1.3.0 in the pipeline and also a newer version of Cake.Git - which in turn, should work in the current GH-Action images
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this PR up, a few changes but I'll take care of them before merging it in.
@@ -43,14 +43,22 @@ jobs: | |||
uses: actions/[email protected] | |||
with: | |||
path: tools | |||
key: ${{ runner.os }}-tools-${{ hashFiles('setup.cake') }} | |||
key: ${{ runner.os }}-tools-${{ hashFiles('setup.cake') }}-${{ hashFiles('.config/dotnet-tools.json') }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version of cake is the only dotnet-tool used, and it is explicitly set in this workflow, as such there is no need to change the cache key here.
@@ -17,7 +17,7 @@ jobs: | |||
runs-on: ${{ matrix.os }} | |||
strategy: | |||
matrix: | |||
os: [windows-2019, ubuntu-18.04, macos-10.15] | |||
os: [windows-2022, ubuntu-22.04, macos-12] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
os: [windows-2022, ubuntu-22.04, macos-12] | |
os: [windows-2022, ubuntu-22.04, macos-13] |
This have been merged in commit 2796c02 |
@all-contributors please add @nils-a for code |
I've put up a pull request to add @nils-a! 🎉 |
and added the required dotnet versions.
fixes #281
fixes #283