Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add propertyUpdated on fromStringArray method #787

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

tiaguinhor
Copy link

@calcinai
Copy link
Owner

calcinai commented Jan 1, 2021

@tiaguinhor thanks for the PR. Just thinking about this, I'm worried it may change some behaviour if this method is being used to load cached data within an application (or something similar).

Do you think adding another parameter to the function would be an acceptable solution to maintain backward compatibility?

@tiaguinhor
Copy link
Author

Hey @calcinai, I think the second argument was already designed on that purpose. But yes, a third argument would be a solution too. I see on the repository we have some TDD, none of them tests those behaviours? Btw, I didn't run them. Cheers, mate.

Mateusz Sosnowski and others added 2 commits February 8, 2022 15:03
@calcinai
Copy link
Owner

calcinai commented Feb 9, 2022

@tiaguinhor adding that propertyUpdated method there will force all requests to contain the entire object, and I'm not sure that is desirable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants