Skip to content

Commit

Permalink
fix: acceptance - use portNumber instead of port
Browse files Browse the repository at this point in the history
port expects a pod port name, but I can't find anything in the k8s
documentation to actually give a name to a port on a pod / container,
it looks like named ports is a concept related only to services.

so switching to `portNumber` instead.
  • Loading branch information
pmauduit committed Dec 5, 2024
1 parent 2364187 commit e9eb813
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion acceptance-tests/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.5.2
version: 0.5.3

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
2 changes: 1 addition & 1 deletion acceptance-tests/templates/prometheus-pm.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ spec:
podMetricsEndpoints:
- interval: {{ .Values.podMonitor.frequency }}
path: {{ .Values.podMonitor.httpPath }}
port: {{ .Values.podMonitor.httpPort | quote }}
portNumber: {{ .Values.podMonitor.httpPort }}
selector:
matchLabels:
{{- with .Values.podMonitor.matchLabels }}
Expand Down
2 changes: 1 addition & 1 deletion acceptance-tests/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,6 @@ podMonitor:
matchLabels:
app.kubernetes.io/name: apache-nas
httpPath: /public/non-regression/report/export/prometheusData.txt
httpPort: "80"
httpPort: 80
# Should be set to a value coherent with the `job.schedule` parameter above.
frequency: 1d

0 comments on commit e9eb813

Please sign in to comment.