Skip to content

Commit

Permalink
Fix permission issue when installing runtests db
Browse files Browse the repository at this point in the history
By consistency, in the commit 0c58332 I changed the path to the odoo-bin
script in both places it was used.
However, as long as 'coverage run' accepts a file which doesn't to be
executable, the first call is executed. We could call python2 or python3
on ${ODOO_BIN_PATH}, but the "odoo" script is there for that. So let's
keep "odoo" for the install and use the "odoo-bin" only for 'coverage
run' where it's required.

For the record, the 'odoo-bin' script is eXecutable in the git
repository, but in some cases we optimize the build of the image by
downloading a tar, and it seems the x flag is absent there.
  • Loading branch information
guewen committed Mar 29, 2018
1 parent c231791 commit 289bb42
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion bin/runtests
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ fi
DB_NAME_TEST=${DB_NAME}_test

PGPASSWORD=$DB_PASSWORD createdb -h $DB_HOST -U $DB_USER -O $DB_USER ${DB_NAME_TEST}
"${ODOO_BIN_PATH}" --stop-after-init --workers=0 --database $DB_NAME_TEST --log-level=warn --without-demo="" -i ${LOCAL_ADDONS}
odoo --stop-after-init --workers=0 --database $DB_NAME_TEST --log-level=warn --without-demo="" -i ${LOCAL_ADDONS}
coverage run --source="${LOCAL_SRC_DIR}" "${ODOO_BIN_PATH}" --stop-after-init --workers=0 --database $DB_NAME_TEST --test-enable --log-level=test --log-handler=":INFO" -u ${LOCAL_ADDONS}
PGPASSWORD=$DB_PASSWORD dropdb -h $DB_HOST -U $DB_USER ${DB_NAME_TEST}

Expand Down

0 comments on commit 289bb42

Please sign in to comment.