-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bin/ utilities #267
fix bin/ utilities #267
Conversation
acc647e
to
ce0c9f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
I'm fixing the CI :-/ |
ce0c9f8
to
db36a3b
Compare
COPY ./src /odoo/src/odoo | ||
COPY ./external-src /odoo/external-src | ||
COPY ./local-src /odoo/local-src | ||
COPY ./odoo/src/odoo /odoo/src/odoo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copying only ./odoo/src/odoo is ok, but you also need to copy ./odoo/src/setup.py to be able to pip install it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right, I have misinterpreted https://github.com/camptocamp/docker-odoo-project/blob/master/test.sh#L66 as moving the extracted directory in a sub directory of /odoo/src
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait I missed your change on https://github.com/camptocamp/docker-odoo-project/pull/267/files#diff-3722d9ba8feb2d3feac8ce71a209a638d4b404e1c53f937188761181594023e2R67-R68
Which confused me.
So far I have not seen where the issue comes from. The path change seems to be the ideal culprit but I didn't find enough evidences to blame it yet. 🧑⚖️ so back to investiguation.
thanks @vrenaville and @yvaucher for looking into this. |
local-src is no longer used -> things are now in /odoo/odoo/addons
e3d02ce
to
4a4084a
Compare
I just rebased + squash |
local-src is no longer used -> things are now in /odoo/odoo/addons