-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add process applications feature #4762
base: develop
Are you sure you want to change the base?
Conversation
@@ -1136,8 +1134,7 @@ export class App extends PureComponent { | |||
if ( | |||
activeTab !== prevState.activeTab || | |||
tabs !== prevState.tabs || | |||
layout !== prevState.layout || | |||
endpoints !== prevState.endpoints |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be used (again) once we support "endpoints" for deployment.
Why would we remove it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Of course fine, if we consider to store the endpoints in a different place, once supported).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it because it's not used at all at the moment and was probably meant to be removed. I would rather reintroduce it again in the context of adding a feature that requires it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We just have to be aware that this is "the data model" that was previously used. We can remove it, but then we'll not remember the data model once we re-introduce an endpoints feature.
@philippfromme Please add "steps to try out" to this PR, so @lmbateman and others can give it a run (to understand the UX we propose). |
cbd00bf
to
3714f6a
Compare
5350340
to
cbc64dc
Compare
cbc64dc
to
3c7d415
Compare
Proposed Changes
Backend
file-context
feature.bpmn
,.dmn
,.form
,.process-application
)Frontend
ProcessApplications
feature to open and close process applications automatically.process-application
file will be createdTry it out
I've added an example process application: a354d21
Open any file in this directory to see the process application.
To run the Camunda Modeler try
npm install && npm start
Follow-ups
References
feature to get reference from and to resourcesAutoCompletions
feature to get autocompletionsCloses #4666
Closes #4675
Closes #4687
Related to #4676
Related to #4664
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/sr
toolCloses {LINK_TO_ISSUE}
orRelated to {LINK_TO_ISSUE}