Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add process applications feature #4762

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

philippfromme
Copy link
Contributor

@philippfromme philippfromme commented Dec 16, 2024

Proposed Changes

Backend

  • adds file-context feature
    • all open files are added to file context
    • metadata is extracted from every supported file type (.bpmn, .dmn, .form, .process-application)
    • process application is opened/closed automatically if opened/closed file is part of process application
    • opening process application watches process application directory

Frontend

  • ProcessApplications feature to open and close process applications automatically
  • new application menu entry to create process application
    • choose directory, empty .process-application file will be created

image

  • new (➕) entry to create process application
  • works the same as new application menu entry

image

  • new button in status bar that is shown when open file is part of process application

image

  • new overlay that shows all files that are part of same process application as open file

image

  • different tab header for files that are part of process application

image

Try it out

I've added an example process application: a354d21

Open any file in this directory to see the process application.

To run the Camunda Modeler try npm install && npm start

Follow-ups

Closes #4666
Closes #4675
Closes #4687
Related to #4676
Related to #4664

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Dec 16, 2024
@@ -1136,8 +1134,7 @@ export class App extends PureComponent {
if (
activeTab !== prevState.activeTab ||
tabs !== prevState.tabs ||
layout !== prevState.layout ||
endpoints !== prevState.endpoints
Copy link
Member

@nikku nikku Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be used (again) once we support "endpoints" for deployment.

Why would we remove it here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Of course fine, if we consider to store the endpoints in a different place, once supported).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it because it's not used at all at the moment and was probably meant to be removed. I would rather reintroduce it again in the context of adding a feature that requires it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just have to be aware that this is "the data model" that was previously used. We can remove it, but then we'll not remember the data model once we re-introduce an endpoints feature.

@nikku
Copy link
Member

nikku commented Jan 6, 2025

@philippfromme Please add "steps to try out" to this PR, so @lmbateman and others can give it a run (to understand the UX we propose).

@philippfromme philippfromme force-pushed the process-applications branch 2 times, most recently from cbd00bf to 3714f6a Compare January 9, 2025 16:44
@philippfromme philippfromme force-pushed the process-applications branch 2 times, most recently from 5350340 to cbc64dc Compare January 10, 2025 15:15
@philippfromme philippfromme marked this pull request as ready for review January 10, 2025 15:21
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jan 10, 2025
@philippfromme philippfromme changed the title Process applications App process applications feature Jan 10, 2025
@philippfromme philippfromme changed the title App process applications feature Add process applications feature Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Review pending
Projects
None yet
2 participants