Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add PR template #134

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

cjdcordeiro
Copy link
Collaborator

This PR adds a new template for all future new PRs.

Here's an example: cjdcordeiro#7

Copy link

@linostar linostar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with exception for the Testing section which can be removed after PR #120 is merged.

Copy link
Member

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

@linostar linostar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cjdcordeiro cjdcordeiro merged commit ab5aa7f into canonical:main Feb 19, 2024
@cjdcordeiro cjdcordeiro deleted the pr-template branch February 19, 2024 17:56
gregory-schiano pushed a commit to gregory-schiano/chisel-releases that referenced this pull request Jun 24, 2024
clay-lake pushed a commit to clay-lake/chisel-releases that referenced this pull request Nov 18, 2024
clay-lake pushed a commit to clay-lake/chisel-releases that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants