-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WD-16849 Rebranded /observability/managed page #14607
base: feature-rebrand-observability
Are you sure you want to change the base?
WD-16849 Rebranded /observability/managed page #14607
Conversation
) * Rebranded observability/what-is-observability * Updated assets * Applied UX Review changes * Design review: line breaks * Replace link + correct label --------- Co-authored-by: Muhammad Ali <[email protected]>
Thanks @muhammad-ali-pk, looks great! Some minor edits:
|
Thanks @eliman11. All done! |
Amazing thank you! Adding UX+1 |
not a full review, I'll leave that to the person who designed the page, but I noticed strips instead of p-sections - can we change to p-sections please? the strip add space at the top, which we do not need. Every element "reserves" as much space as it needs, and doesn't worry about clearing space before it - that's the job of the previous section. The only exception is when there's a background change, but that's not the case here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM a few comments in the code.
Thanks @muhammad-ali-pk ! For the hero section:
For the "Cloud-native applications..." section:
For "Never miss another outage":
For "Reliable monitoring tools you can count on"
For "Multi-cloud ready":
For "Powerful monitoring, simple and predictable price, cost-efficient"
|
@lyubomir-popov Thanks for pointing it out! Done! |
@mattea-turic Thanks Mattea. All done! |
Looks good, thanks again @muhammad-ali-pk ! |
1. Lazy load images out of viewport, while auto for those in visible viewport 2. Updated return link for form to redirect to success banner on form submission
88e6486
to
e413531
Compare
Done
QA
Issue / Card
Fixes #WD-16849