Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WD-16849 Rebranded /observability/managed page #14607

Open
wants to merge 5 commits into
base: feature-rebrand-observability
Choose a base branch
from

Conversation

muhammad-ali-pk
Copy link
Contributor

@muhammad-ali-pk muhammad-ali-pk commented Jan 7, 2025

Done

  • Rebranded /observability/managed page.

QA

  • Open this demo in your web browser.
    • Make sure to test on mobile, tablet and desktop.
  • Make sure the page matches the Figma design and Copydoc

Issue / Card

Fixes #WD-16849

muhammad-ali-pk and others added 2 commits December 20, 2024 16:31
)

* Rebranded observability/what-is-observability

* Updated assets

* Applied UX Review changes

* Design review: line breaks

* Replace link + correct label

---------

Co-authored-by: Muhammad Ali <[email protected]>
@webteam-app
Copy link

@eliman11
Copy link

eliman11 commented Jan 7, 2025

Thanks @muhammad-ali-pk, looks great! Some minor edits:

  • Replace '!' to '.' in 'Let’s change that!' per copy style guide, I've updated the copydoc too
  • Missing link on asterisk in the table ($6,861*)
  • Logo cloud heading should be h2
Screenshot 2025-01-07 at 13 56 43
  • Could we align "All prices are dependent.." footnote to the first column with the prices
Screenshot 2025-01-07 at 13 56 10

@muhammad-ali-pk
Copy link
Contributor Author

Thanks @eliman11. All done!

@eliman11
Copy link

eliman11 commented Jan 8, 2025

Amazing thank you! Adding UX+1

@lyubomir-popov
Copy link
Contributor

not a full review, I'll leave that to the person who designed the page, but I noticed strips instead of p-sections - can we change to p-sections please? the strip add space at the top, which we do not need. Every element "reserves" as much space as it needs, and doesn't worry about clearing space before it - that's the job of the previous section. The only exception is when there's a background change, but that's not the case here.

image

@anthonydillon anthonydillon self-assigned this Jan 8, 2025
Copy link
Contributor

@anthonydillon anthonydillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM a few comments in the code.

templates/observability/managed.html Outdated Show resolved Hide resolved
templates/observability/managed.html Outdated Show resolved Hide resolved
templates/observability/managed.html Outdated Show resolved Hide resolved
templates/observability/managed.html Outdated Show resolved Hide resolved
templates/observability/managed.html Outdated Show resolved Hide resolved
templates/observability/managed.html Outdated Show resolved Hide resolved
templates/observability/managed.html Outdated Show resolved Hide resolved
templates/observability/managed.html Outdated Show resolved Hide resolved
templates/observability/managed.html Outdated Show resolved Hide resolved
templates/observability/managed.html Outdated Show resolved Hide resolved
@mattea-turic
Copy link
Collaborator

mattea-turic commented Jan 8, 2025

Thanks @muhammad-ali-pk !

For the hero section:

  • On screens < 1036px, the H1 and H2 have an extra break between them. Would it be possible to have them sit directly one on top of the other?

For the "Cloud-native applications..." section:

  • As Lyubo mentioned, there's a strip being used here which is resulting in excess whitespace for this section and the one above ("We manage cloud for world leaders" logo section)

For "Never miss another outage":

  • I noticed that part of the image is too white, so I've uploaded a new image if you could this one pls

For "Reliable monitoring tools you can count on"

  • One of the PMs lmk that that the logos/text is outdated and needs to be changed. I've asked him who can help out with this and am waiting for a reply, so could we hold back maybe on deploying for a couple days to see if I get a response first?

For "Multi-cloud ready":

  • Could you wrap the heading & text in a shallow rather than the default padding?

For "Powerful monitoring, simple and predictable price, cost-efficient"

  • Same as above

@muhammad-ali-pk
Copy link
Contributor Author

@lyubomir-popov Thanks for pointing it out! Done!

@muhammad-ali-pk
Copy link
Contributor Author

muhammad-ali-pk commented Jan 8, 2025

@mattea-turic Thanks Mattea. All done!
Sure, I'll add a "don't merge" label until we hear back from the PM. Lemme know whenever.

@mattea-turic
Copy link
Collaborator

Looks good, thanks again @muhammad-ali-pk !

1. Lazy load images out of viewport, while auto for those in visible viewport
2. Updated return link for form to redirect to success banner on form submission
@muhammad-ali-pk muhammad-ali-pk force-pushed the feature-rebrand-observability branch from 88e6486 to e413531 Compare January 9, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants