Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IME paddings #41

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JanPolasek
Copy link

@JanPolasek JanPolasek commented Jan 13, 2025

This reverts commit acfaa0c and fixes #38.

Overall this PR has 2 separate parts:

  1. Revert of acfaa0c. The Stackoverflow thread mentioned in the original code does provide what it says on the tin - a way to get the height of just the keyboard, but in the case of this plugin that isn't the desired value, the bottom inset needs to be both the keyboard height and the status bar height together, otherwise content will be partially underneath the keyboard.
  2. A change of which View the IME padding is applied to. If applied to the decor view it pushes any existing navigation bar background above the keyboard (and over the app's content).

I've tested this on several devices and android versions (11, 14, 15, though of course all on targetSdk 34), but only one app. So if there's anyone for whom alpha.8 worked correctly, there's gotta be something else in how our respective apps are configured, but I really can't think of anything that could do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard overlaps app
1 participant