add dynamic_value::Reader::downcast_struct() #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kvap does this work for you? |
dwrensha
force-pushed
the
downcast-struct
branch
from
11b831f to
234cd8c
Compare
|
@dwrensha this works perfectly, thanks! |
dwrensha
force-pushed
the
downcast-struct
branch
from
d1d3b01 to
c5438c7
Compare
dwrensha
force-pushed
the
downcast-struct
branch
from
c5438c7 to
37dffdd
Compare
This is sad, but seems to be necessary to make Miri accept the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to make a blanket impl of the
DowncastReadertrait for all structs, but I don't see a way to get all the trait bounds/associated types to work out. So this is the next-best thing.