Skip to content

Commit

Permalink
Merge branch 'main' into maven-4
Browse files Browse the repository at this point in the history
  • Loading branch information
carlossg committed Jun 27, 2024
2 parents 9262794 + fdcf2d7 commit 0323262
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 8 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/_template.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
- name: Check out code
uses: actions/checkout@v4
- name: Setup BATS
uses: bats-core/bats-action@c9f3b9ab55d4711876053a7917f3311ee30366bf
uses: bats-core/bats-action@73f0f7d34ec09278ce76030c105fc6a8ddb1d726
- name: Update submodules
run: git submodule update --init

Expand Down Expand Up @@ -95,7 +95,7 @@ jobs:
# https://github.com/docker/build-push-action
- name: Build and push Docker image
id: build-and-push
uses: docker/build-push-action@v5
uses: docker/build-push-action@v6
# if: github.event_name != 'pull_request' # TODO
with:
context: ${{ inputs.directory }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sapmachine-22.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,4 @@ jobs:
uses: ./.github/workflows/_template.yml
with:
directory: sapmachine-22
secrets: inherit
secrets: inherit
5 changes: 2 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,7 @@ Build with the usual

docker build -t maven .

Tests are written using [bats](https://github.com/sstephenson/bats) for Linux images and [pester](https://github.com/pester/Pester) for Windows images
(requires Pester 4.x) under the `tests` dir.
Tests are written using [bats](https://github.com/sstephenson/bats) for Linux images and [pester](https://github.com/pester/Pester) for Windows images under the `tests` dir.

Use the env var TAG to choose what image to run tests against.

Expand Down Expand Up @@ -260,7 +259,7 @@ git submodule init
git submodule update
```

Pester comes with most modern Windows (Windows 10 and Windows Server 2019), but is an older version than required. You may need to follow [this tutorial](https://blog.damianflynn.com/Windows10-Pester/) on upgrading Pester to 4.x.
Pester comes with most modern Windows (Windows 10 and Windows Server 2019), but is an older version than required.


## Adding New Images
Expand Down
2 changes: 1 addition & 1 deletion common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
set -eu

# Default values for 'latest' tag
latestMavenVersion='3.9.7'
latestMavenVersion='3.9.8'
latest=''
default_jdk=eclipse-temurin

Expand Down
2 changes: 1 addition & 1 deletion github-action.ps1
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Install-Module -Name Pester -Force -RequiredVersion 5.0.4
Install-Module -Name Pester -Force -RequiredVersion 5.6.0
Write-Host "Starting"
$dir = $args[0]
$username = $args[1]
Expand Down

0 comments on commit 0323262

Please sign in to comment.