Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfiles for alpine-based images #504

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Conversation

holysoles
Copy link
Contributor

Change Description

Opening this PR to support Alpine-based Corretto images, based on the associated upstream Amazon maintained Corretto Alpine images.

I added installed packages through apk to match the debian images, however I don't think these should be included and should be left to users to extend the image if they want additional utilities like curl on the image, particularly since it increases the complexity for maintaining this project. If that isn't controversial, I'll happily amend my commit to not add any additional packages.

Closes #269

Testing

I've tested building all versions of the images, as well as using Maven to build Java projects for Java 8 and 17. Worked as expected for me.

@carlossg
Copy link
Owner

thanks, I have removed curl as it is not needed and to match the README

@carlossg carlossg merged commit 8db2ffe into carlossg:main Sep 24, 2024
83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce amazoncorretto + alpine images
2 participants