Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add readme #6

Merged
merged 3 commits into from
Jan 5, 2024
Merged

docs: add readme #6

merged 3 commits into from
Jan 5, 2024

Conversation

GCdePaula
Copy link
Collaborator

No description provided.

Copy link
Contributor

@guidanoli guidanoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

offchain ➡️ off-chain
onchain ➡️ on-chain

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@claudioantonio
Copy link

claudioantonio commented Dec 22, 2023

It is good to me, after considering Guilherme's suggestions. 😍

@GCdePaula
Copy link
Collaborator Author

Can you try to follow the instructions to run the node?

@claudioantonio @guidanoli @miltonjonat

Copy link

@miltonjonat miltonjonat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have this!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@miltonjonat
Copy link

Can you try to follow the instructions to run the node?

@claudioantonio @guidanoli @miltonjonat

Didn't work for me:

 => [ 9/15] ADD ./permissionless-arbitration/contracts/src/ ./src/                                                                                                                                                  0.1s
 => [10/15] RUN forge --version                                                                                                                                                                                     0.3s
 => ERROR [11/15] RUN forge build                                                                                                                                                                                   0.5s
------
 > [11/15] RUN forge build:
0.498 Error: 
0.498 failed to resolve file: "/app/contracts/../../machine-emulator-sdk/solidity-step/ready_src/UArchStep.sol": No such file or directory (os error 2); check configured remappings.
0.498     --> "/app/contracts/src/tournament/abstracts/LeafTournament.sol"
0.498         "step/ready_src/UArchStep.sol"

@miltonjonat
Copy link

Ok, now it worked! I needed to download a bunch of submodules - and that's not on the README.

git submodule update --init --recursive

(I admit I don't like submodules very much, but that's a personal thing)

@guidanoli
Copy link
Contributor

guidanoli commented Dec 22, 2023

I had to run the command thrice, because some downloads would fail (but that's probably my internet's fault?).
Also, I had to run git submodule update --init --recursive.
This command should be on the Lua node README.

@GCdePaula
Copy link
Collaborator Author

Nice catches! I've updated with the requests. @claudioantonio can you take a look?

@claudioantonio
Copy link

It worked beautifully @GCdePaula ! ❤️
I only missed a brief description of what is the example, what I executed. 😉

@miltonjonat
Copy link

Yeah a quick description of what is executed would be cool, I was a bit lost too!

@guidanoli
Copy link
Contributor

I agree. I had no idea what was being printed to me, as a newcomer.

@GCdePaula GCdePaula force-pushed the feature/readme branch 9 times, most recently from 92b425b to 40ddeb7 Compare December 24, 2023 14:13
@GCdePaula
Copy link
Collaborator Author

I've added more info to the readme!

I think we can improve the logging itself later in a different PR. It's good for debugging, but as a prototype showing newcomers what's going on, it may be improved.

Let me know if there's more improvements to the readme.

@stephenctw stephenctw linked an issue Dec 25, 2023 that may be closed by this pull request
Copy link

@miltonjonat miltonjonat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@augustoteixeira
Copy link

This is looking great!

@GCdePaula GCdePaula merged commit a01c76e into main Jan 5, 2024
1 check passed
@GCdePaula GCdePaula deleted the feature/readme branch January 5, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve README file with minimal information
5 participants