-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add readme #6
Conversation
8f2b005
to
efab3dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
offchain ➡️ off-chain
onchain ➡️ on-chain
It is good to me, after considering Guilherme's suggestions. 😍 |
efab3dd
to
b20151f
Compare
Can you try to follow the instructions to run the node? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to have this!
Didn't work for me:
|
Ok, now it worked! I needed to download a bunch of submodules - and that's not on the README.
(I admit I don't like submodules very much, but that's a personal thing) |
I had to run the command thrice, because some downloads would fail (but that's probably my internet's fault?). |
Nice catches! I've updated with the requests. @claudioantonio can you take a look? |
It worked beautifully @GCdePaula ! ❤️ |
Yeah a quick description of what is executed would be cool, I was a bit lost too! |
I agree. I had no idea what was being printed to me, as a newcomer. |
92b425b
to
40ddeb7
Compare
40ddeb7
to
a41c41b
Compare
I've added more info to the readme! I think we can improve the logging itself later in a different PR. It's good for debugging, but as a prototype showing newcomers what's going on, it may be improved. Let me know if there's more improvements to the readme. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is looking great! |
No description provided.