Add unit tests to blockchain reader #93
Conversation
stephenctw
force-pushed
the
feature/blockchain-reader-tests
branch
from
02fa90d to
f8a3d71
Compare
|
|
||
| async fn spawn_anvil() -> Result<Child> { | ||
| // Start the Anvil node | ||
| let anvil = Command::new("anvil") |
There was a problem hiding this comment.
I think alloy provides convenience methods to interact with anvil.
There was a problem hiding this comment.
I think it could simplify a lot, such as removing kill_child etc.
There was a problem hiding this comment.
Thanks for the suggestion, I'll look into that.
|
|
||
| #[tokio::test] | ||
| // note: the tests involve interacting with anvil blockchain and a sqlite3 database, can be a bit time consuming (30+ seconds) | ||
| async fn test_readers_sequentially() -> Result<()> { |
There was a problem hiding this comment.
What are the blockers to run everything in parallel?
There was a problem hiding this comment.
I think I was trying to spawn a new anvil process (with fixed port) for each test, but maybe that's not necessary, all tests can share one anvil node.
There was a problem hiding this comment.
I see there are many ways in the codebase to launch anvil and deploy our smart contracts. Is there maybe a way to unify it?
I think the preferable way is through forge scripts. I believe it's possible to store the state of anvil and load it later:
anvil --dump-state state.json
anvil --load-state state.json
Just an idea, but maybe we could have a build target that generates this "template" (spawn anvil with --dump-state, runs forge script, exits), and all the tests that need an anvil+contracts just run anvil --load-state state.json.
There was a problem hiding this comment.
I really like this idea. I think this can be a separate task/PR from the current one.
stephenctw
force-pushed
the
feature/blockchain-reader-tests
branch
from
f8a3d71 to
12b4c31
Compare
No description provided.