Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tag cli args for pkg repo release #1664

Merged
merged 4 commits into from
Dec 25, 2024
Merged

Add tag cli args for pkg repo release #1664

merged 4 commits into from
Dec 25, 2024

Conversation

devanshuVmware
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1639

Does this PR introduce a user-facing change?

Allow Control of Image Tags with introduction of `--tag` flag in `kctrl package repo release`

Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:

@devanshuVmware devanshuVmware changed the title Add tag cli args for pkgr release Add tag cli args for pkg repo release Dec 20, 2024
@devanshuVmware devanshuVmware marked this pull request as draft December 20, 2024 10:09
@devanshuVmware devanshuVmware marked this pull request as ready for review December 20, 2024 11:06
praveenrewar
praveenrewar approved these changes Dec 24, 2024
View reviewed changes
Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cli/test/e2e/package_repo_release_test.go Outdated Show resolved Hide resolved
cli/test/e2e/package_repo_release_test.go Outdated Show resolved Hide resolved
@devanshuVmware
Remove commented code
c65ba79 
Signed-off-by: Devanshu <[email protected]>
@devanshuVmware devanshuVmware merged commit a1c5d04 into carvel-dev:develop Dec 25, 2024
6 checks passed
@devanshuVmware devanshuVmware deleted the 1639-pkg-rls-tag branch December 25, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveenrewar praveenrewar praveenrewar approved these changes

@100mik 100mik Awaiting requested review from 100mik

Assignees
No one assigned
Labels
None yet
Projects
Carvel
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kctrl package repository release Should Allow Control of Image Tags
2 participants
@devanshuVmware @praveenrewar