Merge pull request #141 from Sagilio/master

perf: Improve performance in GetImplicitUsersForPermission
casbin · Mar 19, 2021 · 87dbe83 · 87dbe83
2 parents c7ec287 + 4fd5287
commit 87dbe83
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/NetCasbin/Enforcer.cs b/NetCasbin/Enforcer.cs
@@ -564,12 +564,11 @@ public IEnumerable<string> GetImplicitUsersForPermission(params string[] permiss
 
         public IEnumerable<string> GetImplicitUsersForPermission(IEnumerable<string> permissions)
         {
-            var policySubjects = GetAllSubjects();
-            var groupInherit = model.GetValuesForFieldInPolicyAllTypes("g", 1);
-            var groupSubjects = model.GetValuesForFieldInPolicyAllTypes("g", 0);
-            return policySubjects.Concat(groupSubjects).Distinct()
-                .Where(subject => Enforce(new[]{ subject }.Concat(permissions).Cast<object>().ToArray()))
-                .Except(groupInherit);
+            List<string> policySubjects = GetAllSubjects();
+            List<string> groupInherit = model.GetValuesForFieldInPolicyAllTypes("g", 1);
+            List<string> groupSubjects = model.GetValuesForFieldInPolicyAllTypes("g", 0);
+            return policySubjects.Concat(groupSubjects).Distinct().Except(groupInherit)
+                .Where(subject => Enforce(new[]{ subject }.Concat(permissions).Cast<object>().ToArray()));
         }
 
         #endregion