-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
passkey auto-upgrade need to skip user presence & verification check #432
passkey auto-upgrade need to skip user presence & verification check #432
Conversation
is this repository still active? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nov! Thank you for taking the time to add this!
I'm wondering if this means we can deprecate the config silent_authentication
– which was initially added to pass conformance tests – as it feels to me that it will be easier to understand the purpose of this new user_presence
param. That would probably mean that we should support this param for the assertion response tho.
Other than that, I think we should also add some tests as part of this PR.
In my app, I want to require Plus, I don't know any authenticators which won't require |
and added specs. |
Thanks for the specs! Just one more thing: I realized that we should also add this into the newer relying party API (with the respective specs): https://github.com/cedarcode/webauthn-ruby/blob/b90c6fd/lib/webauthn/relying_party.rb#L84-L90 Sorry for not catching that before 😅 |
I'm not familiar with the newer API, but is this something you're expecting? |
That looks good @nov! Thank you so much! 💯 |
Thanks for your review :-) |
No problem! Before releasing I would like to give a take a last tweak at how this new param and the existent I'm planning on tackling this on Friday. After that I will release a new version! |
new iOS / macOS now support passkey auto upgrade.
it doesn't support neither UV nor UP, and both flags are false by default.
to accept such attestations, those changes are needed.