Use lazy sense calculator #1576
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esseivaju
added
orange
Test summary 4 219 files 6 521 suites 15m 0s ⏱️ Results for commit 4598e55. ♻️ This comment has been updated with latest results. |
|
|
|
Timings are essentially the same as in #1569 (comment), |
|
@sethrj Do you want to merge this, or should we do everything as part of the infix eval PR? |
sethrj
reviewed
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lazy sense calculators require potentially recalculating the same sense multiple times. However, they do not use global memory so they have the potential to be faster, especially once we move to infix evaluation and short-circuiting.
I am splitting this from #1565 to test whether we see any performance improvement without short-circuiting.