core/fetcher: enhance ValidatorSet method with improved error handlin… #4038
+72
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g and safety checks This commit improves the ValidatorSet method in the BlockFetcher by: - Adding validation for negative block heights - Implementing protection against excessive pagination iterations - Improving error messages with detailed context - Optimizing memory allocation for validator slice - Adding context cancellation handling - Enhancing edge case handling for empty validator pages These changes make the method more robust, safer, and easier to debug while maintaining backward compatibility.
MozirDmitriy
requested review from
renaynay,
Wondertan,
vgonkivs,
walldiss and
cristaloleg
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g and safety checks
This commit improves the ValidatorSet method in the BlockFetcher by:
These changes make the method more robust, safer, and easier to debug while maintaining backward compatibility.