Migrate to protobuf javalite #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any update on getting this merged/released? The reason I ask is because I am trying to use Centrifugo on android and firebase is using protobuf-javalite. This causes a build error because multiple classes have the same path and name. |
|
@startoftext hello! I think it's possible to make everything work by excluding protobuf-javalite dependency from your project (see this comment). This way firebase and centrifuge-java should use full protobuf implementation without conflict. I'll try to find a time to merge this and make new release very soon. Maybe in a couple of weeks but can't really promise any concrete deadlines - a bit busy these days at new job and concentrating on Centrifuge/Centrifugo server improvements at my spare time. |
|
Done in #22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.