Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: composition table #1623

Merged
merged 12 commits into from
Oct 25, 2023
Merged

feat: composition table #1623

merged 12 commits into from
Oct 25, 2023

Conversation

jpangelle
Copy link
Contributor

@jpangelle jpangelle commented Oct 3, 2023

Description

This pull request implements a portfolio composition table on the /portfolio page.

Closes #1594

Approvals

  • Dev
  • Designer
  • Product

Screenshots

image

Impact

Portfolio page

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

PR deployed in Google Cloud
URL: https://app-pr1623.k-f.dev
Commit #: 7fc07c4
To access the functions directly check the corresponding deploy Action

@jpangelle jpangelle force-pushed the portfolio-composition-table branch from 855df7e to 75e40d7 Compare October 4, 2023 14:30
@annamehr
Copy link
Contributor

annamehr commented Oct 5, 2023

Looks like pool logo has not been implemented for tokens yet.
Portfolio page is not loading when connecting Görli and Metamask.

It works :)

@jpangelle jpangelle force-pushed the portfolio-composition-table branch from 7eb55ec to ce18268 Compare October 5, 2023 16:08
@jpangelle jpangelle force-pushed the portfolio-composition-table branch 2 times, most recently from 823bc08 to 84e55a8 Compare October 19, 2023 14:46
@@ -0,0 +1,11 @@
import { Text } from '@centrifuge/fabric'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broke out the code from centrifuge-app/src/components/PoolFilter/styles.ts to different components so that we can use it outside of the context of PoolFilter.

@jpangelle jpangelle force-pushed the portfolio-composition-table branch from e1b4864 to 7fc07c4 Compare October 25, 2023 18:00
Copy link
Collaborator

@sophialittlejohn sophialittlejohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@jpangelle jpangelle merged commit 4e248a0 into main Oct 25, 2023
7 checks passed
@jpangelle jpangelle deleted the portfolio-composition-table branch October 25, 2023 19:43
@annamehr
Copy link
Contributor

LGTM! Created a follow up #1668 for the new table design.

gpmayorga pushed a commit that referenced this pull request Nov 23, 2023
hieronx added a commit that referenced this pull request Dec 5, 2023
* abstract deployments/triggers to separate files

* remove triggers and some code cleanup

* Release centrifuge-react and Fabric (#1600)

* Centrifuge App: Fix connecting single account (#1620)

* feat: implement oracle-v2 (#1558)

* Centrifuge App: Remove accrued interest from portfolio card (#1625)

* Moonbeam to demo (#1627)

* CentrifugeJS: Fix transactions (#1622)

* Centrifuge App: Tinlake assets (#1631)

* Centrifuge App: Multicall for Tinlake assets (#1634)

* Centrifuge App: Get all proxies (#1637)

* Create LICENSE (#1646)

* Update support email (#1645)

* Centrifuge App: Pending write-off and epoch changes (#1628)

* Show anamoy pool after chain upgrade (#1648)

* Centrifuge App: Portfolio asset allocation (#1641)

* Centrifuge App: Fix asset class (#1650)

* Centrifuge App: Fix asset detail when subquery is down (#1653)

* Centrifuge App: Fix asset class in pool table (#1652)

* Fix connection guard for evm wallets on cent pool (#1661)

* swap to goldsky subgraph (#1662)

* feat: composition table (#1623)

* Centrifuge App: Table redesign (#1663)

* Centrifuge App: Code splitting and cleaning up unused files (#1660)

* fix: fix trx bug (#1667)

* Centrifuge App: Prime overview page (#1659)

* CentrifugeApp: Portfolio transaction table (#1605)

* Centrifuge App: Liquidity pools investments (#1542)

* Centrifuge App: Fix investor transaction report (#1675)

* fix: safe auth (#1651)

* Centrifuge App: Fixes (#1673)

* fix: use new window (#1676)

* fix: use new window

* use query param

* fix data sharing agreement text

* genericize

* rename

* Centrifuge App: Fix getting loan NFT data (#1685)

* Centrifuge App: Fix formatting for investor transactions (#1686)

* Centrifuge App: Prime detail (#1684)

* CentrifugeJS: Fix query for domain routers (#1692)

* Fix closed asset handling (#1693)

* Centrifuge App: Fix env var (#1694)

* fix: portfolio column spacing (#1698)

* Centrifuge App: Restricted transfers (#1697)

* remove moonbean alpha

* debug commenting on PR

* update demo endpoints

---------

Co-authored-by: Onno Visser <[email protected]>
Co-authored-by: JP <[email protected]>
Co-authored-by: Jeroen <[email protected]>
Co-authored-by: Sophia <[email protected]>
Co-authored-by: Adam Stox <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Portfolio page: composition table
3 participants