Feature branch: runtime upgrade 1038 #1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add pool fee tab and table with drawers for edit and charging fees * Add UI of form to charge fees * Update links * Add successful submit state to charge order * Fetch pool fee data from onchain * Update styles of Drawer header * Enable setting pool fee charge * Fix update order * Remove logs * Add functionality for edit fees drawer * Update metadata when editing pool fees * Query proposed changes * Fix metadata update when item is not being removed * Clean up * Hide edit fee structure button for non admins * Remove unused var * Update styles * Support LP in holders & investor tx reporting (#1912) * Update * Fix * wip * Fix address format * Improve * Naming * Add investor tx type filter * Disable oracles (#1916) --------- Co-authored-by: Jeroen <[email protected]> Co-authored-by: Onno Visser <[email protected]>
* Add pool fees to create pool form * Add create fees to create pool * Add treasury account * Update formik to resolve type errors * Align all columns to the left * Add fees tab to issuer pool * Fix gray background to full width
sophialittlejohn
changed the title
* Fix button spacing in holdings * Update font color of tertiary button * Use tertiary buttons for poolfees table * Show actions only to allowed viewers * Handle cancel better on update fee charge * Update label * Add pool type input to create pool * Add validation for new input * Set correct default fees based on poolType * Add ~ to pending fees * Add pending fees for fixed fees * Fix tilde logic * Fix balance types * Account for epoch time if limit is amountPerSecond * Use last nav for pending fee calculation * Clean up naming * Remove ~ and add pending fees to fixed fee calc * Fix input jumping * Fix multiply by zero on first epoch where previous nav is 0 * Remove logs * Add type decorations for nav runtime api * Fix PoolNav types * Fetch nav value from runtime instead of chain storage * Fix decimal error in fees
gpmayorga
force-pushed
the
runtime-upgrade-1038
branch
from
fde7c31 to
cd843f5
Compare
This was referenced Feb 15, 2024
* Fix typo in tooltip * Place pool type next to pool name
…o runtime-upgrade-1038
* Add copy to clipboard to receiving address in table * Add total pending fees to page summary * Show action column only to receiving address and pool admins * Use maxPayable as amount for non fixed charges * Add fee position column and numbered fees * Fix disabled dropdown label * Rename protocol fees * Add tooltip to fee type label * Add fee position to metadata and update label of fixed fee input * Ajust edit fees drawer * Rename title in charge fees drawer * Remove log * Add * to required fields in create pool form * Update centrifuge-app/src/pages/IssuerCreatePool/PoolFeeInput.tsx * Fix fixed pending fees * Prettier * Fix reserve in chart --------- Co-authored-by: JP <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jpangelle
force-pushed
the
runtime-upgrade-1038
branch
from
a5009ef to
a3d9cba
Compare
* feat: add pool fees runtime api * fix: remove non-existent RPCs * feat: LoansApi v2
…o runtime-upgrade-1038
* Set up fee tx reporting * Use fee id * Setup * Naming * Update centrifuge-app/src/components/Report/FeeTransactions.tsx Co-authored-by: Sophia <[email protected]> --------- Co-authored-by: Sophia <[email protected]>
* Upgrade polkadot packages * Bump version * Upgrade deps in cent-app
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
onnovisser
approved these changes
Mar 18, 2024
|
PR deployed in Google Cloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request...
Closes #
Approvals
Screenshots
Impact