Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes based on feedback #2446

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Fixes based on feedback #2446

merged 2 commits into from
Sep 12, 2024

Conversation

kattylucy
Copy link
Collaborator

@kattylucy kattylucy commented Sep 11, 2024 •
edited
Loading

  • Pool card should display 1,2,3,4 depending on screen size
  • Remove pool min investment field
  • Connect button should be aline with pool title

#2392
#2391

  • Dev

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

PR deployed in Google Cloud
URL: https://app-pr2446.k-f.dev
Commit #: 60e78fd
To access the functions directly check the corresponding deploy Action

@kattylucy kattylucy marked this pull request as ready for review September 11, 2024 19:22
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

PR deployed in Google Cloud
URL: https://pr2446-app-ff-production.k-f.dev
Commit #: 60e78fd
To access the functions directly check the corresponding deploy Action

@kattylucy
Fixes based on feedback
09b3a8b 
- Pool card should display 1,2,3,4 depending on screen size
- Remove pool min investment field
@kattylucy kattylucy enabled auto-merge (squash) September 12, 2024 21:38
@kattylucy kattylucy merged commit bc5d865 into main Sep 12, 2024
11 checks passed
@kattylucy kattylucy deleted the new_design_feedback branch September 12, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophialittlejohn sophialittlejohn sophialittlejohn approved these changes

@onnovisser onnovisser Awaiting requested review from onnovisser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kattylucy @sophialittlejohn