Attestation improvements #2559
Merged
Attestation improvements #2559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR deployed in Google Cloud |
|
PR deployed in Google Cloud |
hieronx
reviewed
Dec 17, 2024
|
|
||
| let signature: { hash: string; publicKey: string } | null = null | ||
| try { | ||
| const message = JSON.stringify(attestation) |
There was a problem hiding this comment.
It is now signing { portfolio: { ... } }. It would be cleaner if it's just signing the inner part, so just { ... }, and then it's combined into a new object that is
{
"portfolio": { ... },
"signature": { ... }
}There was a problem hiding this comment.
I can make this change in the next few days though, don't worry about it :)
Comment on lines
+178
to
+181
| quantity: CurrencyBalance.fromFloat( | ||
| l.pricing.outstandingQuantity.toDecimal(), | ||
| pool.currency.decimals | ||
| ).toString(), |
There was a problem hiding this comment.
Is there a way to check how that rounds? ^^
centrifuge-app/src/pages/NavManagement/NavManagementAssetTable.tsx
Outdated
Show resolved
Hide resolved
….tsx Co-authored-by: Frederik Gartenmeister <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#2557
onchainReservein theassets-section - TAKE from runtimeApiNav.reserveassets-section - currently, cash items are missingprice = -1with right decimals, TAKE from runtimeApiNav.navFeesquantityfield to pool decimals - currently, it is 18 decimalsassetstructureasset→assetId-0foronchainReserveasset→nameretrieved for the asset from ipfs data,onchainReserveforonchainReservenetFeeValuechainId- see json for detailstimestampwhen this was signed toportfolio- unix timestamp in secondssignatureto be a struct containingsignatureandpublicKeyof signernetAssetValueis correct - TAKE from runtimeApiNav.totalApprovals
Screenshots
Impact