Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remark tags, and attestation signature type #2565

Merged
merged 5 commits into from
Dec 20, 2024
Merged

Add remark tags, and attestation signature type #2565

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
45ad2e9
Fix reserve value in NAV management
hieronx Dec 20, 2024
8d32b1e
Fix remark attestation content
hieronx Dec 20, 2024
41f100e
Merge branch 'main' of https://github.com/centrifuge/apps into fix-re…
hieronx Dec 20, 2024
2b7fba1
Add signature type
hieronx Dec 20, 2024
d9c4142
Remove console.log
hieronx Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions centrifuge-app/src/pages/NavManagement/NavManagementAssetTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,23 +200,23 @@ export function NavManagementAssetTable({ poolId }: { poolId: string }) {
},
}

let signature: { hash: string; publicKey: string } | null = null
let signature: { hash: string; publicKey: string; type: 'evm' | 'substrate' } | null = null
try {
const message = JSON.stringify(attestation.portfolio)
if (provider) {
const signer = await provider.getSigner()
const sig = await signer.signMessage(message)
const hash = keccak256(toUtf8Bytes(`\x19Ethereum Signed Message:\n${message.length}${message}`))
const recoveredPubKey = SigningKey.recoverPublicKey(hash, sig)
signature = { hash: sig, publicKey: recoveredPubKey }
signature = { hash: sig, publicKey: recoveredPubKey, type: 'evm' }
} else if (substrate.selectedAccount?.address && substrate?.selectedWallet?.signer?.signRaw) {
const { address } = substrate.selectedAccount
const { signature: sig } = await substrate.selectedWallet.signer.signRaw({
address: address,
data: stringToHex(message),
type: 'bytes',
})
signature = { hash: sig, publicKey: addressToHex(address) }
signature = { hash: sig, publicKey: addressToHex(address), type: 'substrate' }
}
} catch {}
if (!signature) return null
Expand Down Expand Up @@ -258,7 +258,10 @@ export function NavManagementAssetTable({ poolId }: { poolId: string }) {
return api.tx.oraclePriceFeed.feed(feed, CurrencyBalance.fromFloat(f.value, 18))
}),
api.tx.oraclePriceCollection.updateCollection(poolId),
api.tx.remarks.remark([{ Named: attestationHash }], api.tx.loans.updatePortfolioValuation(poolId)),
api.tx.remarks.remark(
[{ Named: `attestation:${poolId}:${attestationHash}` }],
api.tx.loans.updatePortfolioValuation(poolId)
),
api.tx.utility.batch(updateTokenPricesTxs),
]

Expand Down
Loading