Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusted Inventory and Group API hostFilter documention #3128

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Adjusted Inventory and Group API hostFilter documention #3128

merged 3 commits into from
Apr 4, 2024

Conversation

aleksandrychev
Copy link
Contributor

Ticket: ENT-9959

@aleksandrychev
Copy link
Contributor Author

@nickanderson @craigcomstock please review

craigcomstock
craigcomstock requested changes Nov 27, 2023
View reviewed changes
api/enterprise-api-ref/personal-groups.markdown Outdated Show resolved Hide resolved
api/enterprise-api-ref/personal-groups.markdown Outdated Show resolved Hide resolved
api/enterprise-api-ref/shared-groups.markdown Outdated Show resolved Hide resolved
api/enterprise-api-ref/shared-groups.markdown Outdated Show resolved Hide resolved
craigcomstock
craigcomstock previously requested changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@craigcomstock craigcomstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost! I missed one! :O

api/enterprise-api-ref/inventory.markdown Outdated Show resolved Hide resolved
@nickanderson
Copy link
Member

@cf-bottom jenkins please

@cf-bottom
Copy link

Sure, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/434/

Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-434/output/_site/

nickanderson
nickanderson approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@nickanderson nickanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is OK.

I noticed that we moved from hostsFilter to hostFilter. Seems like a breaking API change, but I guess that is OK since that change is related to Groups and that has not yet been released in LTS. Inventory got the addition of hostFilter.

@nickanderson
Copy link
Member

nickanderson commented Nov 28, 2023 •
edited
Loading

The Inventory API doesn't seem to work as expected for me.

  • Querying using only hostFilter includes seems to return all hosts, not only the included ones.
  • Querying using only hostFilter excludes seems to return all hosts, not excluding any.

See my test queries and comments here:

@olehermanse
Copy link
Member

@cf-bottom jenkins, please

@cfengine cfengine deleted a comment from cf-bottom Jan 5, 2024
@cf-bottom
Copy link

Alright, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/484/

Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-484/output/_site/

craigcomstock
craigcomstock reviewed Jan 5, 2024
View reviewed changes
Copy link
Contributor

@craigcomstock craigcomstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some ideas for improvement.

api/enterprise-api-ref/personal-groups.markdown Outdated Show resolved Hide resolved
api/enterprise-api-ref/shared-groups.markdown Show resolved Hide resolved
api/enterprise-api-ref/personal-groups.markdown Outdated Show resolved Hide resolved
@aleksandrychev
Copy link
Contributor Author

@craigcomstock or @nickanderson please merge

@nickanderson
Copy link
Member

@cf-bottom jenkins please

@cf-bottom
Copy link

Sure, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/568/

Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-568/output/_site/

@nickanderson
Copy link
Member

@cf-bottom jenkins please

@cf-bottom
Copy link

Alright, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/569/

Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-569/output/_site/

@nickanderson
Fixed rendering of JSON
be7510c 
- Indented so that JSON was under filter.
- Added blank line before JSON to make it render multi-line
@nickanderson
Copy link
Member

@cf-bottom jenkins please

@cf-bottom
Copy link

Sure, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/570/

Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-570/output/_site/

@nickanderson nickanderson merged commit 01519aa into cfengine:master Apr 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigcomstock craigcomstock craigcomstock approved these changes

@nickanderson nickanderson nickanderson approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aleksandrychev @nickanderson @cf-bottom @olehermanse @craigcomstock