PrivateKey generation from entropy #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimoneBronzini
requested changes
Oct 6, 2020
btcpy/structs/crypto.py
Outdated
| Returns: | ||
| A random hexadecimal string of length 2 * nbytes. | ||
| """ | ||
| return secrets.token_hex(nbytes) |
There was a problem hiding this comment.
You are supposed to return a PrivateKey object here, this will just return a random hexadecimal string.
There was a problem hiding this comment.
Hi @SimoneBronzini , thanks for the reminder. I've made a correction there such that it returns a PrivateKey object, and I fix the random hexadecimal string to be of 32 bytes (for simplicity). Please let me know if that works or not? Thanks!
|
Hi @SimoneBronzini I have made the change you mentioned and pushed the commit. May you have a look and let me know if that's OK? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a @staticmethod in the
PrivateKeyclass called generate that creates a PrivateKey, which is a random hexadecimal string withnbytesbytes, using python's secrets standard module. A corresponding unit test is added.Please let me know if the pull request meets the requirement, or there are any suggested changes.
Thank you!
#31