disprove tx #388
Merged
disprove tx #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekrembal
reviewed
Jan 3, 2025
core/src/actor.rs
Outdated
| @@ -286,6 +286,36 @@ impl Actor { | |||
| Ok(sig_hash) | |||
| } | |||
|
|
|||
| #[tracing::instrument(err(level = tracing::Level::ERROR), ret(level = tracing::Level::TRACE))] | |||
| pub fn convert_tx_to_script_spend( | |||
ceyhunsen
requested changes
Jan 3, 2025
ekrembal
requested changes
Jan 8, 2025
core/src/builder/sighash.rs
Outdated
|
|
||
| let sig_hash = sighash_cache.taproot_key_spend_signature_hash( | ||
| txin_index, | ||
| &bitcoin::sighash::Prevouts::All(&tx.prevouts), |
There was a problem hiding this comment.
This part is inccorect, it should be like:
&match sighash_type {
Some(TapSighashType::SinglePlusAnyoneCanPay) => {
bitcoin::sighash::Prevouts::One(input_index, prevouts[input_index].clone())
}
_ => bitcoin::sighash::Prevouts::All(prevouts),
},
core/src/builder/sighash.rs
Outdated
| let mut sighash_cache: SighashCache<&mut bitcoin::Transaction> = | ||
| SighashCache::new(&mut tx_handler.tx); | ||
|
|
||
| let prevouts = bitcoin::sighash::Prevouts::All(&tx_handler.prevouts); |
There was a problem hiding this comment.
This part is inccorect, it should be like:
&match sighash_type {
Some(TapSighashType::SinglePlusAnyoneCanPay) => {
bitcoin::sighash::Prevouts::One(input_index, prevouts[input_index].clone())
}
_ => bitcoin::sighash::Prevouts::All(prevouts),
},
core/src/builder/transaction.rs
Outdated
|
|
||
| let tx_outs = vec
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds disprove tx, challenge tx and happy reimburse tx.