[MOB-1676] 버튼 미구현 컨텐츠 구현 #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sodp5
force-pushed
the
feature/button-contents
branch
from
7ca3690 to
584ea54
Compare
sodp5
force-pushed
the
feature/button-contents
branch
from
584ea54 to
cce212c
Compare
vvvvvoin
requested changes
Aug 7, 2024
Comment on lines
+17
to
+18
| internal val emojiSize: Dp, | ||
| internal val avatarSize: BezierAvatarSize, |
There was a problem hiding this comment.
이 수치들은 따로 피그마 권한으로만 볼 수 있느건가요?
There was a problem hiding this comment.
이쪽 스레드 내용 보고 넣은거였어요!
여기에 들어가는 값은 16/20/24 고 없으면 variants에 추가되어야함 으로 이해했어서용
https://desk.channel.io/root/threads/groups/(CT)BezierRedesign-244958/66a9c7f6c49bd5d51d75/66b3087b0bf3451de5b6
vvvvvoin
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loader, Avatar, Emoji 값을 적용합니다.
figma: https://www.figma.com/design/8J76noM3T1Sp5cNPhnYQiG/Action?node-id=112-6059&t=PeOyStx7eyqPnUpD-4