[MOB-1873] 토글 이모지 버튼 추가 #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvvvvoin
force-pushed
the
v2-emoji-button
branch
from
e6941b7 to
2bd3684
Compare
sodp5
suggested changes
Sep 4, 2024
| variant: BezierToggleEmojiButtonVariant, | ||
| modifier: Modifier = Modifier, | ||
| enabled: Boolean = true, | ||
| onClick: () -> Unit, |
There was a problem hiding this comment.
onClick 매개변수를 위로 올리는 게 매개변수 순서상 좀 더 일관된다는 느낌을 받는데 어떻게 생각하시나요??
아래 문서에는, trailing lambda가 있는 경우 Composable로 오인할 수 있다.
라는 내용으로 근거삼고 있긴 하네용 Layout 쓰는 경험 생각해보면 그럴 수 있을것 같기도 해요
https://github.com/androidx/androidx/blob/androidx-main/compose/docs/compose-component-api-guidelines.md#parameters-order
There was a problem hiding this comment.
아 이건 잘못 쓴게 완전 맞습니다ㅋㅋㅋㅋ
sodp5
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
피그마 : https://www.figma.com/design/fPXP9zfjZU9NyARnhTWL6o/Input?node-id=543-145&t=WDIP1n5b9DcYgACa-1