Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOB-1901] 토글 이모지 버튼 그룹 추가 #69

Merged
merged 3 commits into from
Sep 13, 2024
Merged

[MOB-1901] 토글 이모지 버튼 그룹 추가 #69

merged 3 commits into from
Sep 13, 2024

Conversation

vvvvvoin
Copy link
Contributor

@vvvvvoin vvvvvoin commented Aug 26, 2024 •
edited
Loading

image

@vvvvvoin vvvvvoin self-assigned this Aug 26, 2024
@channeltalk ChannelTalk
Copy link

channeltalk bot commented Aug 26, 2024

https://desk.channel.io/#/channels/1/team_chats/groups/136448/66cc9d336526ff2aed61

@vvvvvoin vvvvvoin force-pushed the v2-toggle-emoji-button-group branch from 627a4a3 to 73abc02 Compare September 9, 2024 06:24
@vvvvvoin vvvvvoin marked this pull request as ready for review September 9, 2024 06:24
sodp5
sodp5 reviewed Sep 11, 2024
View reviewed changes
Copy link
Contributor

@sodp5 sodp5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 컴포넌트를 토글시킬 방법이 없는것 같아요! 상태를 전달해주는 로직이 추가되어야 할것 같습니다
  • ToggleEmojiButton << 이거 Source까지 이름 붙여놓으면 어떠신가요? 패키지는 구분되어있긴 한데 Source라고 되어있으면 더더욱 쓰면 안될것 같이 보여서요! internal도 붙여줘야 할것 같습니당

@sodp5 sodp5 merged commit 2228058 into channel-io:v2 Sep 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sodp5 sodp5 sodp5 approved these changes

Assignees

@vvvvvoin vvvvvoin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vvvvvoin @sodp5