Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive, check,json and exec command with firejail for inspec #8246

Merged
merged 20 commits into from
Oct 25, 2023

Conversation

YashviJain01
Copy link
Collaborator

@YashviJain01 YashviJain01 commented Oct 5, 2023

🔩 Description: What code changed, and why?

Inspec archive, json and check commands will be run in the sandbox environment now.

For executing the command in sandbox env, the file is copyied into newly created tmp directory in /tmp folder.

We are reading the output using standard output file and standard error files.

⛓️ Related Resources

https://chefio.atlassian.net/browse/CHEF-5691

👍 Definition of Done

A sandbox environment is created with a profile now.

👟 How to Build and Test the Change

rebuild components/compliance-service/

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

https://teams.microsoft.com/l/message/19:meeting_NzZhMzg5NDktNDA0Ni00MjMzLTg3NjctMTVhNmVlZGI2N2U1@thread.v2/1698235398723?context=%7B%22contextType%22%3A%22chat%22%7D

https://teams.microsoft.com/l/message/19:meeting_NzZhMzg5NDktNDA0Ni00MjMzLTg3NjctMTVhNmVlZGI2N2U1@thread.v2/1698233310493?context=%7B%22contextType%22%3A%22chat%22%7D

@netlify
Copy link

netlify bot commented Oct 5, 2023

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit afe52a1
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/6538e4be51a5490008e87efb

@YashviJain01 YashviJain01 marked this pull request as ready for review October 25, 2023 06:30
Yashvi Jain and others added 16 commits October 25, 2023 12:13
Signed-off-by: Yashvi Jain <[email protected]>
Signed-off-by: Yashvi Jain <[email protected]>
Signed-off-by: Yashvi Jain <[email protected]>
Signed-off-by: Yashvi Jain <[email protected]>
Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>
Signed-off-by: Yashvi Jain <[email protected]>
Signed-off-by: Yashvi Jain <[email protected]>
Signed-off-by: Yashvi Jain <[email protected]>
Signed-off-by: Yashvi Jain <[email protected]>
Signed-off-by: Kallol Roy <[email protected]>
Signed-off-by: Kallol Roy <[email protected]>
Signed-off-by: Yashvi Jain <[email protected]>
Signed-off-by: Yashvi Jain <[email protected]>
@YashviJain01 YashviJain01 changed the title Draft Code for Security Archive, check,json and exec command with firejail for inspec Oct 25, 2023
Yashvi Jain added 3 commits October 25, 2023 13:03
Signed-off-by: Yashvi Jain <[email protected]>
Signed-off-by: Yashvi Jain <[email protected]>
Signed-off-by: Yashvi Jain <[email protected]>
Signed-off-by: Yashvi Jain <[email protected]>
@sonarqube-for-infrastructure-prod

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

@kalroy kalroy merged commit ee25d5e into main Oct 25, 2023
3 of 4 checks passed
@kalroy kalroy deleted the yashvi/CHEF-6820 branch October 25, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants