-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Archive, check,json and exec command with firejail for inspec #8246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for chef-automate processing.
|
Dmaddu
force-pushed
the
yashvi/CHEF-6820
branch
from
October 16, 2023 13:46
bb34c37
to
1b585d0
Compare
YashviJain01
force-pushed
the
yashvi/CHEF-6820
branch
from
October 23, 2023 10:24
20612bc
to
573542f
Compare
Signed-off-by: Yashvi Jain <[email protected]>
Signed-off-by: Yashvi Jain <[email protected]>
Signed-off-by: Yashvi Jain <[email protected]>
Signed-off-by: Yashvi Jain <[email protected]>
Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>
Signed-off-by: Yashvi Jain <[email protected]>
Signed-off-by: Yashvi Jain <[email protected]>
Signed-off-by: Yashvi Jain <[email protected]>
Signed-off-by: Yashvi Jain <[email protected]>
Signed-off-by: Yashvi Jain <[email protected]>
Signed-off-by: Kallol Roy <[email protected]>
Signed-off-by: Kallol Roy <[email protected]>
Signed-off-by: Yashvi Jain <[email protected]>
Signed-off-by: Yashvi Jain <[email protected]>
Signed-off-by: Yashvi Jain <[email protected]>
Signed-off-by: Yashvi Jain <[email protected]>
YashviJain01
force-pushed
the
yashvi/CHEF-6820
branch
from
October 25, 2023 06:43
573542f
to
e000a28
Compare
YashviJain01
changed the title
Draft Code for Security
Archive, check,json and exec command with firejail for inspec
Oct 25, 2023
YashviJain01
requested review from
kalroy,
daveaugustus,
SahithiMy and
Sahiba3108
October 25, 2023 07:22
Signed-off-by: Yashvi Jain <[email protected]>
Signed-off-by: Yashvi Jain <[email protected]>
Signed-off-by: Yashvi Jain <[email protected]>
Sahiba3108
requested changes
Oct 25, 2023
Signed-off-by: Yashvi Jain <[email protected]>
kalroy
approved these changes
Oct 25, 2023
Sahiba3108
approved these changes
Oct 25, 2023
daveaugustus
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
Inspec archive, json and check commands will be run in the sandbox environment now.
For executing the command in sandbox env, the file is copyied into newly created tmp directory in /tmp folder.
We are reading the output using standard output file and standard error files.
⛓️ Related Resources
https://chefio.atlassian.net/browse/CHEF-5691
👍 Definition of Done
A sandbox environment is created with a profile now.
👟 How to Build and Test the Change
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spell
in any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable
https://teams.microsoft.com/l/message/19:meeting_NzZhMzg5NDktNDA0Ni00MjMzLTg3NjctMTVhNmVlZGI2N2U1@thread.v2/1698235398723?context=%7B%22contextType%22%3A%22chat%22%7D
https://teams.microsoft.com/l/message/19:meeting_NzZhMzg5NDktNDA0Ni00MjMzLTg3NjctMTVhNmVlZGI2N2U1@thread.v2/1698233310493?context=%7B%22contextType%22%3A%22chat%22%7D