Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jay/chef 6031 #8261

Merged
merged 17 commits into from
Nov 7, 2023
Merged

Jay/chef 6031 #8261

merged 17 commits into from
Nov 7, 2023

Conversation

jayvikramsharma1
Copy link
Collaborator

@jayvikramsharma1 jayvikramsharma1 commented Oct 16, 2023 •
edited
Loading

🔩 Description: What code changed, and why?

Rotate cluster certificate at once

⛓️ Related Resources

https://chefio.atlassian.net/browse/CHEF-6031

https://progresssoftware.sharepoint.com/:v:/s/ChefCoreC/EbrFjpcILt9GqdufQPDGqXgB0vEQGSQfhMbl3T4ijjHAhA?e=lQJRqx

👍 Definition of Done

Dev tested

👟 How to Build and Test the Change

automate-cli build

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

https://progresssoftware.sharepoint.com/:v:/s/ChefCoreC/EbrFjpcILt9GqdufQPDGqXgB0vEQGSQfhMbl3T4ijjHAhA?e=lQJRqx

@netlify
Copy link

netlify bot commented Oct 16, 2023 •
edited
Loading

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit 1c26643
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/654409db9d372f00096c3f07

punitmundra and others added 10 commits October 25, 2023 13:24
@punitmundra @jayvikramsharma1
add the certificate template
91143f1 
Signed-off-by: punitmundra <[email protected]>
@jayvikramsharma1
cert rotate from template
58ee1f8 
Signed-off-by: Jay Sharma <[email protected]>
@jayvikramsharma1
patching frontend config
3e4a3b7 
Signed-off-by: Jay Sharma <[email protected]>
@jayvikramsharma1
cluster certificate patch working code
27140bc 
Signed-off-by: Jay Sharma <[email protected]>
@jayvikramsharma1
putting frontend on maintenance mode before rotating certws
85515dc 
Signed-off-by: Jay Sharma <[email protected]>
@jayvikramsharma1
added test cases for get certs form template
e966e25 
Signed-off-by: Jay Sharma <[email protected]>
@jayvikramsharma1
correction of filename in cert-config generation
2ebd156 
Signed-off-by: Jay Sharma <[email protected]>
@jayvikramsharma1
adding more test cases
ac76999 
Signed-off-by: Jay Sharma <[email protected]>
@jayvikramsharma1
adding validation on certificates before stopping traffic to frontends
0663100 
Signed-off-by: Jay Sharma <[email protected]>
@jayvikramsharma1
adding defer statement to turn off maintenance mode
0aed8f1 
Signed-off-by: Jay Sharma <[email protected]>
@jayvikramsharma1 jayvikramsharma1 requested a review from a team as a code owner October 27, 2023 05:58
@github-actions github-actions bot added the documentation Anything related to the Automate docs. label Oct 27, 2023
punitmundra
punitmundra approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@punitmundra punitmundra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do resolve the comment

@jayvikramsharma1 jayvikramsharma1 changed the title Jay/chef 6031 [WIP]Jay/chef 6031 Nov 2, 2023
@jayvikramsharma1
resolving review comments
b6b66b6 
Signed-off-by: Jay Sharma <[email protected]>
@sonarqube-for-infrastructure-prod SonarQube for Infrastructure (Prod)
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 59.6% 59.6% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

@jayvikramsharma1
regfactoring
1c26643 
Signed-off-by: Jay Sharma <[email protected]>
@jayvikramsharma1 jayvikramsharma1 changed the title [WIP]Jay/chef 6031 Jay/chef 6031 Nov 3, 2023
@punitmundra punitmundra merged commit 605ebb6 into main Nov 7, 2023
2 of 3 checks passed
@punitmundra punitmundra deleted the jay/CHEF-6031 branch November 7, 2023 10:15
swatiganesh pushed a commit that referenced this pull request Apr 16, 2024
@jayvikramsharma1 @punitmundra @swatiganesh
Jay/chef 6031 (#8261)
3b67097 
* add the certificate template

Signed-off-by: punitmundra <[email protected]>

* cert rotate from template

Signed-off-by: Jay Sharma <[email protected]>

* patching frontend config

Signed-off-by: Jay Sharma <[email protected]>

* cluster certificate patch working code

Signed-off-by: Jay Sharma <[email protected]>

* putting frontend on maintenance mode before rotating certws

Signed-off-by: Jay Sharma <[email protected]>

* added test cases for get certs form template

Signed-off-by: Jay Sharma <[email protected]>

* correction of filename in cert-config generation

Signed-off-by: Jay Sharma <[email protected]>

* adding more test cases

Signed-off-by: Jay Sharma <[email protected]>

* adding validation on certificates before stopping traffic to frontends

Signed-off-by: Jay Sharma <[email protected]>

* adding defer statement to turn off maintenance mode

Signed-off-by: Jay Sharma <[email protected]>

* replacing fmt with logger

Signed-off-by: Jay Sharma <[email protected]>

* adding exclution on testcase pem files

Signed-off-by: Jay Sharma <[email protected]>

* adding testfile in credscan excl;ustion

Signed-off-by: Jay Sharma <[email protected]>

* fixing failing testcases

Signed-off-by: Jay Sharma <[email protected]>

* adding docs

Signed-off-by: Jay Sharma <[email protected]>

* resolving review comments

Signed-off-by: Jay Sharma <[email protected]>

* regfactoring

Signed-off-by: Jay Sharma <[email protected]>

---------

Signed-off-by: punitmundra <[email protected]>
Signed-off-by: Jay Sharma <[email protected]>
Co-authored-by: punitmundra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvtejaswi bvtejaswi bvtejaswi left review comments

@ArvinthC3000 ArvinthC3000 ArvinthC3000 left review comments

@punitmundra punitmundra punitmundra approved these changes

@vivek-yadav vivek-yadav vivek-yadav approved these changes

@Dmaddu Dmaddu Awaiting requested review from Dmaddu

Assignees
No one assigned
Labels
documentation Anything related to the Automate docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jayvikramsharma1 @vivek-yadav @punitmundra @ArvinthC3000 @bvtejaswi