Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new flag for status and service-versions command to accept hab license #8267

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

bvtejaswi
Copy link
Collaborator

@bvtejaswi bvtejaswi commented Oct 18, 2023

🔩 Description: What code changed, and why?

In some environment they are not allowing to set the env variable.
For chef-automate status and chef-automate service-versions command internally we are using env variable in a command sudo HAB_LICENSE=accept-no-persist hab svc status so to accept hab license we are making use of a new flag which will accept the license
In automate installation setting the HAB_LICENSE is required and it is mandatory, with out setting this env flag we can not install the standalone automate and automate-HA.
By doing this ticket we are just adding the support for the flag --accept-hab-licence for chef-automate status command.

⛓️ Related Resources

https://chefio.atlassian.net/browse/CHEF-6574

👍 Definition of Done

Tested with chef-automate status and chef-automate service-versions backend flags

👟 How to Build and Test the Change

build automate-cli

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

video
chef-automate status --accept-hab-license
chef-automate service-versions --accept-hab-license
Here's how the output looks if its accepting license via flag accept-hab-license same behaviour for both status and service-versions command
chef-automate status --pg --accept-hab-license

@netlify
Copy link

netlify bot commented Oct 18, 2023

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit 0529c6e
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/653610375ef7700008027628

@bvtejaswi bvtejaswi force-pushed the bvtejaswi/add-new-flag-to-status-command branch from 43a43d3 to 19e6bfe Compare October 23, 2023 06:11
Signed-off-by: Tejaswi Bondila <[email protected]>
@sonarqube-for-infrastructure-prod

@punitmundra punitmundra merged commit 2f89741 into main Oct 23, 2023
4 checks passed
@punitmundra punitmundra deleted the bvtejaswi/add-new-flag-to-status-command branch October 23, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants