-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remvoing config patch for old configs in upgrade and add/remove node #8296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arvinth C <[email protected]>
ArvinthC3000
requested review from
vivek-yadav,
jayvikramsharma1,
punitmundra,
karunesh-tech and
bvtejaswi
November 20, 2023 08:30
👷 Deploy Preview for chef-automate processing.
|
punitmundra
requested changes
Nov 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump the package automate-backend-deploment
Signed-off-by: Arvinth C <[email protected]>
punitmundra
approved these changes
Nov 20, 2023
punitmundra
approved these changes
Nov 21, 2023
bvtejaswi
approved these changes
Nov 21, 2023
Signed-off-by: Arvinth C <[email protected]>
Signed-off-by: Arvinth C <[email protected]>
SonarQube Quality Gate 0 Bugs No Coverage information |
anees-progress
pushed a commit
that referenced
this pull request
Nov 30, 2023
…8296) * Remoing config patch for old configs in upgrade and add/remove node Signed-off-by: Arvinth C <[email protected]> * Trigger build Signed-off-by: Arvinth C <[email protected]> * Stash for save and sync config for upgrade flow Signed-off-by: Arvinth C <[email protected]> * Removing stash Signed-off-by: Arvinth C <[email protected]> --------- Signed-off-by: Arvinth C <[email protected]>
anees-progress
pushed a commit
that referenced
this pull request
Nov 30, 2023
…8296) * Remoing config patch for old configs in upgrade and add/remove node Signed-off-by: Arvinth C <[email protected]> * Trigger build Signed-off-by: Arvinth C <[email protected]> * Stash for save and sync config for upgrade flow Signed-off-by: Arvinth C <[email protected]> * Removing stash Signed-off-by: Arvinth C <[email protected]> --------- Signed-off-by: Arvinth C <[email protected]>
swatiganesh
pushed a commit
that referenced
this pull request
Apr 16, 2024
…8296) * Remoing config patch for old configs in upgrade and add/remove node Signed-off-by: Arvinth C <[email protected]> * Trigger build Signed-off-by: Arvinth C <[email protected]> * Stash for save and sync config for upgrade flow Signed-off-by: Arvinth C <[email protected]> * Removing stash Signed-off-by: Arvinth C <[email protected]> --------- Signed-off-by: Arvinth C <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
When user upgrade the bundle to latest, some configuration belongs to Automate config which are updated are reverting back to initial values. In this PR, that is addressed
⛓️ Related Resources
Jira ticket: https://chefio.atlassian.net/browse/CHEF-8418
👍 Definition of Done
👟 How to Build and Test the Change
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spell
in any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable
In the below screenshot, when the deployment done, the original base path highlighted would be "elasticsearch", which lated updated to "opensearch".
After upgrade, the same value is intact
Screenshot