Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding health check for backup gateway #8297

Merged
merged 6 commits into from
Nov 23, 2023
Merged

Conversation

ArvinthC3000
Copy link
Collaborator

@ArvinthC3000 ArvinthC3000 commented Nov 21, 2023

🔩 Description: What code changed, and why?

Added health check to backup-gateway to make sure the service is running healthy)

⛓️ Related Resources

Jira ticket: https://chefio.atlassian.net/browse/CHEF-2845

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Demo Video: Health check for Backup gateway.mp4

Copy link

netlify bot commented Nov 21, 2023

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit 60cb732
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/655efe9e0a4b12000849be87

curlOpts="-sS --fail --max-time 2 -o /dev/null -s -w %{http_code}"
curlOpts="$curlOpts --cert {{pkg.svc_config_path}}/public.crt"
curlOpts="$curlOpts --key {{pkg.svc_config_path}}/private.key"
curlOpts="$curlOpts --cacert /hab/svc/automate-gateway/config/root_ca.crt"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

automate-gateway -> backup-gateway
In case backup-gateway doesnot have the certificate then we have to find the way how it will get the certificate

Copy link
Collaborator Author

@ArvinthC3000 ArvinthC3000 Nov 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added root-ca.crt (separated from public.crt) in backup-gateway

@bvtejaswi
Copy link
Collaborator

check your pipelines

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@punitmundra punitmundra merged commit 71956bf into main Nov 23, 2023
4 checks passed
@punitmundra punitmundra deleted the ar/backupGateway_hc branch November 23, 2023 08:19
anees-progress pushed a commit that referenced this pull request Nov 30, 2023
* Adding health check for backup gateway

Signed-off-by: Arvinth C <[email protected]>

* Health check log

Signed-off-by: Arvinth C <[email protected]>

* Addinf root ca in seperate file for backup gateway

Signed-off-by: Arvinth C <[email protected]>

* Addinf root ca in seperate file for backup gateway

Signed-off-by: Arvinth C <[email protected]>

* trigger build

Signed-off-by: Arvinth C <[email protected]>

* Pipeline fix

Signed-off-by: Arvinth C <[email protected]>

---------

Signed-off-by: Arvinth C <[email protected]>
anees-progress pushed a commit that referenced this pull request Nov 30, 2023
* Adding health check for backup gateway

Signed-off-by: Arvinth C <[email protected]>

* Health check log

Signed-off-by: Arvinth C <[email protected]>

* Addinf root ca in seperate file for backup gateway

Signed-off-by: Arvinth C <[email protected]>

* Addinf root ca in seperate file for backup gateway

Signed-off-by: Arvinth C <[email protected]>

* trigger build

Signed-off-by: Arvinth C <[email protected]>

* Pipeline fix

Signed-off-by: Arvinth C <[email protected]>

---------

Signed-off-by: Arvinth C <[email protected]>
swatiganesh pushed a commit that referenced this pull request Apr 16, 2024
* Adding health check for backup gateway

Signed-off-by: Arvinth C <[email protected]>

* Health check log

Signed-off-by: Arvinth C <[email protected]>

* Addinf root ca in seperate file for backup gateway

Signed-off-by: Arvinth C <[email protected]>

* Addinf root ca in seperate file for backup gateway

Signed-off-by: Arvinth C <[email protected]>

* trigger build

Signed-off-by: Arvinth C <[email protected]>

* Pipeline fix

Signed-off-by: Arvinth C <[email protected]>

---------

Signed-off-by: Arvinth C <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants