-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for Erlang R19 #105
base: main
Are you sure you want to change the base?
Conversation
@eryx67 Thanks for the contribution! Our DCO policy (read about it here: https://blog.chef.io/2016/09/19/introducing-developer-certificate-of-origin/) requires that your commit has a Signed-Off-By line affirming you agree to the DCO. You can add it to your existing commit by doing something like: git commit --amend -s --no-edit and then force-pushing to your branch. cc @chef/erlangers for review |
Signed-off-by: eryx67 <[email protected]>
Signed-off-by: eryx67 <[email protected]>
Signed-off-by: eryx67 <[email protected]>
Signed-off-by: eryx67 <[email protected]>
Signed-off-by: eryx67 <[email protected]>
I was just looking at what it would take to update us to OTP 21 and saw this PR. Currently github is marking this as unmergable because not every commit has DCO and travis is failing. While some of the commits have DCO, not all do. What I would suggest we do is break this PR up into a couple of pieces, each rebased on master, and updated to have DCO. I'm thinking something like this would work:
Thoughts? I see you are maintaining a fork, and I think if we do the commits in the above order the git histories will be reconcilable by merge cleanly. |
It seems that Erlang 19 has only one (typed) declaration for records in AST