Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: linting warnings and initializer logic #47

Closed

Conversation

huaweigu
Copy link
Contributor

Summary

This PR addresses the linting warnings and corrects the logic in WalletStorageInitializable.

Detail

Changeset

  • Resolve all warnings (thanks to Ashutosh!)
  • Correct the logic in the unused code within WalletStorageInitializable
  • Eliminate redundant calls in SingleOwnerMSCA constructor
  • Add a sanity check != address(0) in SingleOwnerMSCA

Checklist

  • Did you add new tests and confirm all tests pass? (yarn test)
  • Did you update relevant docs? (docs are found in the docs folder)
  • Do your commits follow the Conventional Commits standard?
  • Does your PR title also follow the Conventional Commits standard?
  • If you have a breaking change, is it correctly reflected in your commit message? (e.g. feat!: breaking change)
  • Did you run lint (yarn lint) and fix any issues?
  • Did you run formatter (yarn format:check) and fix any issues (yarn format:write)?

Testing

  • No new tests have been added for style changes.
  • New tests have been included for the fixes:
    • For the walletStorageInitializer fix, I have forked the OZ JavaScript tests and rewritten them using Foundry.
    • The remaining two changes are already covered by existing tests (we don't allow installing address(0) and testInitializeSingleOwnerMSCAWithRuntimeValidation).

Documentation

n/a

@huaweigu huaweigu marked this pull request as draft November 15, 2024 20:13
@huaweigu huaweigu closed this Nov 15, 2024
@huaweigu huaweigu deleted the fix/initializer-logic branch November 15, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant