fix: linting warnings and initializer logic #47
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the linting warnings and corrects the logic in
WalletStorageInitializable
.Detail
Changeset
WalletStorageInitializable
SingleOwnerMSCA
constructor!= address(0)
inSingleOwnerMSCA
Checklist
yarn test
)docs
folder)feat!: breaking change
)yarn lint
) and fix any issues?yarn format:check
) and fix any issues (yarn format:write
)?Testing
walletStorageInitializer
fix, I have forked the OZ JavaScript tests and rewritten them using Foundry.address(0)
andtestInitializeSingleOwnerMSCAWithRuntimeValidation
).Documentation
n/a