feat(release): sign commits created by release actor #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files.github/workflows/conventional-commit-release.yaml
|
wparr-circle
force-pushed
the
wparr-circle-patch-1
branch
from
b655626 to
9413d52
Compare
wparr-circle
force-pushed
the
wparr-circle-patch-1
branch
from
2886d1f to
70d5c84
Compare
jscaltreto
approved these changes
Aug 2, 2024
wparr-circle
added a commit
that referenced
this pull request
Aug 7, 2024
## Summary Updating the conventional commit release secrets which are used, due to recent disabling of organization setting used to allow pull request creation (and approval) via the automatic GITHUB_ACTIONS tokens. This follows on from the setup in #16 which adds some extra support for gpg signing the release branch commits. This will setup @circle-bot-releases as the actor for creating release prs and publishing releases.
wparr-circle
pushed a commit
that referenced
this pull request
Aug 7, 2024
🤖 I have created a release *beep* *boop* --- ## [1.3.0](v1.2.0...v1.3.0) (2024-08-07) ### Features * **release:** sign commits created by release actor ([#16](#16)) ([dfadf96](dfadf96)) ### Bug Fixes * conventional commit release secrets ([#17](#17)) ([7c49cea](7c49cea)) ### Miscellaneous Chores * **deps:** upgrade action versions to use node 20 ([#15](#15)) ([a82bc74](a82bc74)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To ensure that commits aren't unsigned, or unverified when vigilant mode is enabled - we need to ensure that the commit associated with a release is signed by a GPG key associated with the release actor.
ie.
Release please unfortunately still does not support signing commits with a gpg key directly - per issue googleapis/release-please#1314
However, we can checking the branch and use this to ensure the commits are signed.
After signing introducing this change - we get verified commits
