Skip to content

Commit

Permalink
Fix serving extraenvs (#258)
Browse files Browse the repository at this point in the history
* Fixed: missing extraEnvs

* Changed: bump version
  • Loading branch information
valeriano-manassero authored Oct 27, 2023
1 parent 5ed9673 commit d13ad20
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 5 deletions.
6 changes: 2 additions & 4 deletions charts/clearml-serving/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: clearml-serving
description: ClearML Serving Helm Chart
type: application
version: "1.5.0"
version: "1.5.1"
appVersion: "1.3.0"
kubeVersion: ">= 1.21.0-0 < 1.29.0-0"
home: https://clear.ml
Expand Down Expand Up @@ -33,7 +33,5 @@ dependencies:
condition: grafana.enabled
annotations:
artifacthub.io/changes: |
- kind: added
description: external file mount
- kind: fixed
description: missinf parameters application in deploymets from values file
description: missing extraEnvs
2 changes: 1 addition & 1 deletion charts/clearml-serving/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# ClearML Kubernetes Serving

![Version: 1.5.0](https://img.shields.io/badge/Version-1.5.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.3.0](https://img.shields.io/badge/AppVersion-1.3.0-informational?style=flat-square)
![Version: 1.5.1](https://img.shields.io/badge/Version-1.5.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.3.0](https://img.shields.io/badge/AppVersion-1.3.0-informational?style=flat-square)

ClearML Serving Helm Chart

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ spec:
- name: CLEARML_EXTRA_PYTHON_PACKAGES
value: '{{ join " " .Values.clearml_serving_statistics.extraPythonPackages }}'
{{- end }}
{{- with .Values.clearml_serving_statistics.extraEnvironment }}
{{- toYaml . | nindent 12 }}
{{- end }}
image: "{{ .Values.clearml_serving_statistics.image.repository }}:{{ .Values.clearml_serving_statistics.image.tag }}"
name: {{ include "clearmlServing.fullname" . }}-statistics
ports:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,9 @@ spec:
- name: CLEARML_EXTRA_PYTHON_PACKAGES
value: '{{ join " " .Values.clearml_serving_triton.extraPythonPackages }}'
{{- end }}
{{- with .Values.clearml_serving_triton.extraEnvironment }}
{{- toYaml . | nindent 12 }}
{{- end }}
image: "{{ .Values.clearml_serving_triton.image.repository }}:{{ .Values.clearml_serving_triton.image.tag }}"
name: {{ include "clearmlServing.fullname" . }}-triton
ports:
Expand Down

0 comments on commit d13ad20

Please sign in to comment.