Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate CLEARML__secure__auth__token_secret in apiserver-asyncdelete-deployment.yaml #322

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

benglewis
Copy link
Contributor

What this PR does / why we need it:
Fixes duplicate environment variable

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Verify the work you plan to merge addresses an existing issue (If not, open a new one) (required)
  • Check your branch with helm lint (required)
  • Update version in Chart.yaml according semver rules (required)
  • Substitute annotations section in Chart.yaml annotating implementations (useful for Artifecthub changelog) (required)
  • Update chart README using helm-docs (required)

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@benglewis
Copy link
Contributor Author

@filippo-clearml Is there any chance that this will be merged? It is blocking me upgrading to the latest Helm chart with the latest ClearML :/

@benglewis
Copy link
Contributor Author

@filippo-clearml @valeriano-manassero I don't mean to be a bugbear, but we are stuck unable to upgrade our ClearML version because of this bug and so I would really like to see this PR merged 🙏

@filippo-clearml filippo-clearml self-assigned this Sep 23, 2024
@filippo-clearml
Copy link
Collaborator

Hey @benglewis sorry for the delay.
Of course, we're going to merge this soon! Thanks for the contribution :)

Apply request to change `Chart.yaml`
@benglewis
Copy link
Contributor Author

@filippo-clearml I applied the change to Chart.yaml. Hopefully you can merge this :)

@filippo-clearml filippo-clearml merged commit 02a87e1 into clearml:main Sep 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants