Fix some premature reloads with chokidar awaitWriteFinish #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes some cases of cloudflare#34 where miniflare reloads the worker js file as it is being written to (e.g. by webpack), rather than when it has finished emitting. Seems to particularly be a problem on Windows.
|
Hey! 👋 Thanks for the PR! 🙂 Unfortunately, I haven't had time to maintain Miniflare 1, so it's kinda in limbo... However, I've been working on Miniflare 2 which is hopefully going to be released very soon. You can try out a pre-release with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some cases of #34 where miniflare reloads the worker js file as it is being written to (e.g. by webpack), rather than when it has finished emitting. Seems to particularly be a problem on Windows.