Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify coloring code #1218

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Unify coloring code #1218

merged 1 commit into from
Dec 6, 2024

Conversation

prymitive
Copy link
Collaborator

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.68.0-20-g47f7e99
Number of rules parsed 4
Number of rules checked 4
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

Copy link

github-actions bot commented Dec 6, 2024

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   39.91m ± 2%   39.23m ± 1%       ~ (p=0.052 n=10)
CheckRules-4     8.519 ± 2%    8.525 ± 2%       ~ (p=0.853 n=10)
geomean         583.1m        578.3m       -0.82%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   27.41Mi ± 0%   27.40Mi ± 0%       ~ (p=0.123 n=10)
CheckRules-4    973.0Mi ± 0%   974.4Mi ± 0%       ~ (p=0.143 n=10)
geomean         163.3Mi        163.4Mi       +0.07%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   131.7k ± 0%   131.7k ± 0%       ~ (p=0.179 n=10)
CheckRules-4    14.13M ± 0%   14.13M ± 0%       ~ (p=0.165 n=10)
geomean         1.364M        1.364M       +0.03%

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.03%. Comparing base (e5bd98e) to head (47f7e99).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1218      +/-   ##
==========================================
- Coverage   95.03%   95.03%   -0.01%     
==========================================
  Files         105      105              
  Lines       12593    12587       -6     
==========================================
- Hits        11968    11962       -6     
  Misses        475      475              
  Partials      150      150              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prymitive prymitive merged commit 46a07ef into main Dec 6, 2024
20 checks passed
@prymitive prymitive deleted the color branch December 6, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants