Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bioresources to build #803

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Add bioresources to build #803

merged 1 commit into from
Oct 20, 2023

Conversation

bgyori
Copy link
Contributor

@bgyori bgyori commented Oct 18, 2023

This PR makes a small change to build.sbt which allows bioresources to be made available when doing publishLocal. This is necessary for #802.

@kwalcock
Copy link
Member

Thanks, again, @bgyori. I'm not sure what we should do with this. Since it is already in a branch, perhaps we should just leave it there for safe keeping. @enoriega may want to weigh in.

@bgyori
Copy link
Contributor Author

bgyori commented Oct 20, 2023

I think this PR is not that controversial - it just adds bioresources to be created with publishLocal which "doesn't hurt" so to speak, so I think it could be merged. Though I might be missing something.

@enoriega
Copy link
Member

@kwalcock I am surprised that I worked before given that the project does load resources from the bioresources subproject.
Regardless, if it doesn't hurt I don't object

@enoriega enoriega merged commit 122dbaa into master Oct 20, 2023
@kwalcock
Copy link
Member

I just didn't want to presume. The aggregation will work not just for publishLocal, but also publish, release, and test as far as I know. The publish in particular would have consequences.

@enoriega
Copy link
Member

The subproject only consists of assets, no code whatsoever. So I am not worried about it. What I am still puzzled by if how we could read the resources and config of that subproject if it wasn't aggregated before

@kwalcock
Copy link
Member

The dependsOn is probably handling it. The processors subproject dependsOn bioresources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants