Skip to content

Commit

Permalink
Fix errors in spell_list_targeting and creature_spell_list
Browse files Browse the repository at this point in the history
  • Loading branch information
miraco committed Oct 14, 2023
1 parent 40ecf15 commit c4ddc3e
Showing 1 changed file with 28 additions and 0 deletions.
28 changes: 28 additions & 0 deletions Updates/0231_spell_list_target_fix.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
-- Fix Attack - random player mana user, only used SELECT_FLAG_PLAYER
-- Attack - random player non tank mana user
-- introduced in https://github.com/cmangos/tbc-db/commit/cf42c2c8c5bea9f2f505077a235638ffd2f83582
UPDATE creature_spell_targeting SET Param3 = 6 WHERE Id = 105;
UPDATE creature_spell_targeting SET Param3 = 6 WHERE Id = 106;

-- Reinsert Attack - random player not in melee
-- Deletet in https://github.com/cmangos/tbc-db/commit/624b3757677024e50c85a6cf69b06d31513cb49b
DELETE FROM creature_spell_targeting WHERE Id IN(107);
INSERT INTO creature_spell_targeting(Id, Type, Param1, Param2, Param3, UnitCondition, Comments) VALUES
('107', '1', '0', '0', '130', '-1', 'Attack - random player not in melee');

This comment has been minimized.

Copy link
@AnonXS

AnonXS Dec 30, 2023

Member

why does this have SELECT_FLAG_POWER_MANA? ik befor it was already 6 which was also wrong, but |4 seems wrong to me, e.g any raid mechanic will not hit rogues, warriors with this xD well maybe its all spells that indeed target mana users but this is not mentioned here.

thats why i dont like bad descriptions. . .



-- Reinser Missing 25% including self and Missing 25% excluding self
-- Deletet in https://github.com/cmangos/tbc-db/commit/624b3757677024e50c85a6cf69b06d31513cb49b
DELETE FROM `creature_spell_targeting` WHERE `Id` IN (206,207,208,209);
INSERT INTO `creature_spell_targeting` (`Id`, `Type`, `Param1`, `Param2`, `Param3`, `UnitCondition`, `Comments`) VALUES
(206, 2, 25, 1, 1, -1, 'Support - Missing 25% including self'),
(207, 2, 25, 1, 0, -1, 'Support - Missing 25% excluding self'),
(208, 2, 75, 1, 1, -1, 'Support - missing 75% including self'),
(209, 2, 75, 1, 0, -1, 'Support - missing 75% excluding self');

-- Now also fix spell_list that used the wrong spell_list_target
-- Baroness Dorothea Millstipe - Mana Burn - Random Mana User
UPDATE creature_spell_list SET TargetId = '105' WHERE Id = '1987501' AND Position = '0' AND SpellId = '29405';

-- Lady Catriona Von'Indi - Greater Heal - missing 75% including self
UPDATE creature_spell_list SET TargetId = '208' WHERE Id = '1987201' AND Position = '1' AND SpellId = '29564';

0 comments on commit c4ddc3e

Please sign in to comment.