Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applied feedback to the moving-levels review template #1387

Merged
merged 10 commits into from
Nov 8, 2024

Conversation

eddie-knight
Copy link
Collaborator

No description provided.

@eddie-knight eddie-knight requested a review from mnm678 October 10, 2024 02:29
Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for tag-security ready!

Name Link
🔨 Latest commit 45252a4
🔍 Latest deploy log https://app.netlify.com/sites/tag-security/deploys/672e37e9d143090008744a9e
😎 Deploy Preview https://deploy-preview-1387--tag-security.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@eddie-knight
Copy link
Collaborator Author

cc/ @brandtkeller

Copy link
Collaborator

@mnm678 mnm678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, but overall this is a good clarification

project-resources/moving-levels-review-template.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look good - couple lint/spelling items to address

@brandtkeller
Copy link
Collaborator

Link check is failing and should be fixed in #1403 - we can merge that PR and use this one after updating to ensure the changes worked as expected.

@brandtkeller brandtkeller merged commit 38d8049 into main Nov 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants